feat(cloudflare)!: Revert set enableRpcTracePropagation to true by default - #23350
Open
JPeer264 wants to merge 3 commits into
Open
feat(cloudflare)!: Revert set enableRpcTracePropagation to true by default#23350JPeer264 wants to merge 3 commits into
JPeer264 wants to merge 3 commits into
Conversation
JPeer264
requested review from
isaacs and
mydea
and removed request for
a team
August 12, 2026 12:54
JPeer264
requested review from
andreiborza and
nicohrubec
and removed request for
isaacs
August 12, 2026 12:55
andreiborza
reviewed
Aug 12, 2026
| ``` | ||
|
|
||
| - The `enableRpcTracePropagation` option now defaults to `true`. Trace context is propagated across RPC calls (service bindings, Durable Objects, WorkerEntrypoints) unless you explicitly set `enableRpcTracePropagation: false`. | ||
| > **TODO(v11):** This might change to `enableRpcTracePropagation: true` by default. This depends on the outcomes of #20525 |
Member
There was a problem hiding this comment.
We should drop the TODO tho right?
Member
Author
There was a problem hiding this comment.
For now I wanted to revert it only and update the migration.md properly with the new changes. Since we have now a different migration.md file it might make sense to remove it entirely here for now
andreiborza
approved these changes
Aug 12, 2026
JPeer264
commented
Aug 12, 2026
nicohrubec
approved these changes
Aug 12, 2026
| * MyDOBase, | ||
| * ); | ||
| * | ||
| * // WorkerEntrypoint side (receiver) |
Contributor
There was a problem hiding this comment.
Bug: The migration guide incorrectly states enableRpcTracePropagation defaults to true. The PR changes the default to false, but the documentation was not updated to reflect this.
Severity: HIGH
Suggested Fix
Update the migration documentation in docs/migration/v11-end-state.md. Correct the statement about enableRpcTracePropagation to reflect that it now defaults to false and is an opt-in feature. Emphasize that users must explicitly set enableRpcTracePropagation: true on both the caller and receiver to enable full trace propagation.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/cloudflare/src/client.ts#L226
Potential issue: The PR reverts the default value of `enableRpcTracePropagation` from
`true` back to `false`. However, the migration documentation in
`docs/migration/v11-end-state.md` was not updated to reflect this change. The guide
still claims the option defaults to `true`. This discrepancy will cause users following
the migration guide to believe RPC trace propagation is enabled by default, leading to a
silent loss of tracing data when it is actually disabled. They will not see RPC spans in
their traces and may only discover this when debugging production issues.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverts #23079
It is bad if we actually set this on by default, not because of performance, but because other uninstrumented services could fail. Instead we will add an allow list like
instrumentPrototypeMethodswas before which is opt-in when using without Vite and when using it with the Vite plugin we allow list all bindings within one deployment automatically and all other services are opt-in (follow up PRs).This is the only way to not modify RPC calls to external deployments. See #23233 (comment)