Skip to content

feat(cloudflare)!: Set enableRpcTracePropagation to true by default - #23079

Merged
JPeer264 merged 2 commits into
jp/cloudflare-agent-rpc-proxy-private-fieldsfrom
jp/enable-rpc-trace-propagation-true
Aug 7, 2026
Merged

feat(cloudflare)!: Set enableRpcTracePropagation to true by default#23079
JPeer264 merged 2 commits into
jp/cloudflare-agent-rpc-proxy-private-fieldsfrom
jp/enable-rpc-trace-propagation-true

Conversation

@JPeer264

@JPeer264 JPeer264 commented Aug 6, 2026

Copy link
Copy Markdown
Member

closes #20525
closes #20525

This swaps the default of the enableRpcTracePropagation field

@JPeer264 JPeer264 self-assigned this Aug 6, 2026
@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

JS-2292

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 30.15 kB - -
@sentry/browser - with treeshaking flags 28.35 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.66 kB - -
@sentry/browser (incl. Tracing) 47.56 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.57 kB - -
@sentry/browser (incl. Tracing, Profiling) 52.31 kB - -
@sentry/browser (incl. Tracing, Replay) 86.93 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.36 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.66 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 104.29 kB - -
@sentry/browser (incl. Feedback) 47.48 kB - -
@sentry/browser (incl. sendFeedback) 34.98 kB - -
@sentry/browser (incl. FeedbackAsync) 40.13 kB - -
@sentry/browser (incl. Metrics) 31.22 kB - -
@sentry/browser (incl. Logs) 31.44 kB - -
@sentry/browser (incl. Metrics & Logs) 32.13 kB - -
@sentry/react 31.95 kB - -
@sentry/react (incl. Tracing) 49.81 kB - -
@sentry/vue 35.25 kB - -
@sentry/vue (incl. Tracing) 49.57 kB - -
@sentry/svelte 30.17 kB - -
CDN Bundle 32.16 kB - -
CDN Bundle (incl. Tracing) 47.83 kB - -
CDN Bundle (incl. Logs, Metrics) 33.7 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.21 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.03 kB - -
CDN Bundle (incl. Tracing, Replay) 85.47 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.79 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.29 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.61 kB - -
CDN Bundle - uncompressed 95.33 kB - -
CDN Bundle (incl. Tracing) - uncompressed 142.84 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.96 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 146.82 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.66 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 262.09 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.06 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 275.8 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 279.75 kB - -
@sentry/nextjs (client) 52.39 kB - -
@sentry/sveltekit (client) 48.01 kB - -
@sentry/core/server 65.58 kB - -
@sentry/core/browser 51.82 kB - -
@sentry/node 119.28 kB -0.01% -1 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 83.3 kB -0.01% -1 B 🔽
@sentry/aws-serverless 92.61 kB -0.01% -1 B 🔽
@sentry/cloudflare (withSentry) - minified 214.16 kB +0.74% +1.55 kB 🔺
@sentry/cloudflare (withSentry) 528.83 kB +0.76% +3.94 kB 🔺

View base workflow run

@JPeer264
JPeer264 force-pushed the jp/enable-rpc-trace-propagation-true branch from 36e5016 to 1184a51 Compare August 6, 2026 12:55
@JPeer264
JPeer264 marked this pull request as ready for review August 6, 2026 12:55
@JPeer264
JPeer264 requested a review from a team as a code owner August 6, 2026 12:55
@JPeer264
JPeer264 requested review from chargome, isaacs, mydea and nicohrubec and removed request for a team, isaacs and mydea August 6, 2026 12:55

@chargome chargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would update the docs here otherwise lgtm!

Comment on lines +203 to +204
* **Important:** This option is enabled by default. Set it to `false` to opt out, e.g. if you
* do not want trace context to leave your Worker via RPC calls.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the JSDoc example below should show an example of opting out now, not the other way around

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! Gonna change that

@JPeer264
JPeer264 force-pushed the jp/enable-rpc-trace-propagation-true branch from ce80ac7 to 6e9cf9b Compare August 7, 2026 06:36
@JPeer264
JPeer264 merged commit abffcfa into develop Aug 7, 2026
85 of 113 checks passed
@JPeer264
JPeer264 deleted the jp/enable-rpc-trace-propagation-true branch August 7, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do CPU performance benchmarks if instrumentingPrototypeMethods has a big drawback

4 participants