Skip to content

fix(deno): Enable sessions for HTTP requests #23313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AG0708 wants to merge 1 commit into
base: develop
Choose a base branch
from
+49 −3
Open

fix(deno): Enable sessions for HTTP requests #23313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/deno/src/integrations/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ const _denoHttpIntegration = ((options: DenoHttpIntegrationOptions = {}) => {
onSpanCreated: options.onIncomingSpanCreated,
onSpanEnd: options.onIncomingSpanEnd,
errorMonitor,
sessions: false,
});
subscribe(HTTP_ON_SERVER_REQUEST, onHttpServerRequest);

Expand Down
51 changes: 49 additions & 2 deletions packages/deno/test/deno-http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
// <reference lib="deno.ns" />

import * as http from 'node:http';
import type { TransactionEvent } from '@sentry/core';
import { getMainCarrier } from '@sentry/core';
import type { Envelope, SessionAggregates, TransactionEvent } from '@sentry/core';
import { forEachEnvelopeItem, getMainCarrier } from '@sentry/core';
import { assert } from 'https://deno.land/std@0.212.0/assert/assert.ts';
import { assertEquals } from 'https://deno.land/std@0.212.0/assert/assert_equals.ts';
import { assertExists } from 'https://deno.land/std@0.212.0/assert/assert_exists.ts';
import type { DenoClient } from '../build/esm/index.js';
import { init, startSpan } from '../build/esm/index.js';
import { makeTestTransport } from './transport.ts';

function resetGlobals(): void {
getMainCarrier().__SENTRY__ = undefined;
Expand Down Expand Up @@ -110,6 +111,52 @@ Deno.test({
},
});

Deno.test({
name: 'denoHttpIntegration: node:http incoming request records a release-health session',
async fn() {
resetGlobals();
const envelopes: Envelope[] = [];
const client = init({
dsn: 'https://username@domain/123',
release: '1.0.0',
transport: makeTestTransport(envelope => {
envelopes.push(envelope);
}),
});

const server = http.createServer((_req, res) => {
res.end('ok');
});
const port: number = await new Promise(resolve => {
server.listen(0, '127.0.0.1', () => {
resolve((server.address() as { port: number }).port);
});
});

const response = await fetch(`http://127.0.0.1:${port}/health`);
assertEquals(await response.text(), 'ok');
await new Promise<void>(resolve => server.close(() => resolve()));
await client.flush(2_000);

let sessionAggregates: SessionAggregates | undefined;
for (const envelope of envelopes) {
forEachEnvelopeItem(envelope, item => {
const [headers, body] = item;
if (headers.type === 'sessions') {
sessionAggregates = body as SessionAggregates;
}
});
}

assertExists(sessionAggregates);
assertEquals(sessionAggregates.attrs?.release, '1.0.0');
assertEquals(sessionAggregates.aggregates.length, 1);
assertEquals(sessionAggregates.aggregates[0]?.exited, 1);
assertEquals(sessionAggregates.aggregates[0]?.errored, 0);
assertEquals(sessionAggregates.aggregates[0]?.crashed, 0);
},
});

Deno.test({
name: 'denoHttpIntegration: node:http outgoing request creates a child http.client span',
async fn() {
Expand Down