fix(deno): Enable sessions for HTTP requests - #23313
Open
AG0708 wants to merge 1 commit into
Open
Conversation
Deno disabled release-health sessions for incoming node:http requests even though the shared HTTP instrumentation defaults them on. Preserve the shared default and cover it with a real request regression test. Co-Authored-By: OpenAI Codex <codex@openai.com> Signed-off-by: Abhinav Gorrepati <gorrepatiabhinav1@gmail.com>
AG0708
marked this pull request as ready for review
August 12, 2026 01:15
AG0708
requested review from
JPeer264 and
mydea
and removed request for
a team
August 12, 2026 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno's
node:httpserver integration disabled release-health sessions eventhough the shared HTTP instrumentation enables them by default. Keeping the
shared default aligns Deno with the other server runtimes and restores session
aggregates for incoming requests when a release is configured.
Root cause
The Deno integration passed
sessions: falsewhen it subscribed to shared HTTPserver instrumentation. There is no Deno-specific duplicate instrumentation
that requires that override.
yarn lint) & (yarn test).Fixes #22888