Skip to content

fix: Diagnostics channel Node v18 #21631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timfish wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −4
Open

fix: Diagnostics channel Node v18 #21631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7f82cb
fix: Diagnostics channel Node v18
timfish Jun 18, 2026
3485417
oops
timfish Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/opentelemetry/src/tracingChannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* using Node.js diagnostic_channel's `bindStore` mechanism.
*/
import type { TracingChannel, TracingChannelSubscribers } from 'node:diagnostics_channel';
import { tracingChannel as nativeTracingChannel } from 'node:diagnostics_channel';
import * as diagnosticsChannel from 'node:diagnostics_channel';
import type { Span } from '@opentelemetry/api';
import { context, trace } from '@opentelemetry/api';
import { logger } from '@sentry/core';
Expand Down Expand Up @@ -53,9 +53,10 @@ export function tracingChannel<TData extends object = object>(
channelNameOrInstance: string,
transformStart: OtelTracingChannelTransform<TData>,
): OtelTracingChannel<TData, TracingChannelContextWithSpan<TData>> {
const channel = nativeTracingChannel<TracingChannelContextWithSpan<TData>, TracingChannelContextWithSpan<TData>>(
channelNameOrInstance,
) as unknown as OtelTracingChannel<TData, TracingChannelContextWithSpan<TData>>;
const channel = diagnosticsChannel.tracingChannel<
TracingChannelContextWithSpan<TData>,
TracingChannelContextWithSpan<TData>
>(channelNameOrInstance) as unknown as OtelTracingChannel<TData, TracingChannelContextWithSpan<TData>>;
Comment thread
sentry[bot] marked this conversation as resolved.

let lookup: AsyncLocalStorageLookup | undefined;
try {
Expand Down
Loading