Skip to content

fix: Diagnostics channel Node v18#21631

Open
timfish wants to merge 2 commits into
developfrom
timfish/fix/node-v18-dc
Open

fix: Diagnostics channel Node v18#21631
timfish wants to merge 2 commits into
developfrom
timfish/fix/node-v18-dc

Conversation

@timfish

@timfish timfish commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

tracingChannel wasn't added until Node v18.19.0, v19.9.0 and we technically support v18.0.0.

@timfish timfish requested a review from a team as a code owner June 18, 2026 11:04
@timfish timfish requested review from JPeer264, Copilot, logaretm and mydea and removed request for a team June 18, 2026 11:04
Copilot AI reviewed Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sentry[bot]
sentry Bot reviewed Jun 18, 2026
View reviewed changes
Comment thread packages/opentelemetry/src/tracingChannel.ts
mydea
mydea approved these changes Jun 18, 2026
View reviewed changes

@mydea mydea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering, why is this different? 🤔 is it only being picked up at runtime this way, and thus does not break if that is not used? but either way, if it works...

@timfish

timfish commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

only being picked up at runtime this way, and thus does not break if that is not used?

Yes this moves the error from import evaluation to runtime. This only impacts very new integrations so while they are not in the defaults this is not likely to break existing users. Allthough the new integrations won't support Node <= v18.18

I can make tracingChannel also return undefined and make all the integrations handle that too if you think it's worth it?

@mydea

mydea commented Jun 18, 2026

Copy link
Copy Markdown
Member

only being picked up at runtime this way, and thus does not break if that is not used?

Yes this moves the error from import evaluation to runtime. This only impacts very new integrations so while they are not in the defaults this is not likely to break existing users. Allthough the new integrations won't support Node <= v18.18

I can make tracingChannel also return undefined and make all the integrations handle that too if you think it's worth it?

I think it's fine as long as these are not default, which they will likely not be in node until v11, at which point this will be moot anyhow as we'll bump to node 20+ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

Copilot code review Copilot Copilot left review comments

@mydea mydea mydea approved these changes

@logaretm logaretm logaretm approved these changes

@JPeer264 JPeer264 Awaiting requested review from JPeer264 JPeer264 is a code owner automatically assigned from getsentry/team-javascript-sdks-server

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish @mydea @logaretm