fix(replay): Set sentry.replay_id attribute on streamed spans#20897
Open
nicohrubec wants to merge 1 commit into
Open
fix(replay): Set sentry.replay_id attribute on streamed spans#20897nicohrubec wants to merge 1 commit into
sentry.replay_id attribute on streamed spans#20897nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sentry.replay_id attribute on streamed spanssentry.replay_id attribute on streamed spans
Contributor
size-limit report 📦
|
chargome
approved these changes
May 15, 2026
Member
chargome
left a comment
There was a problem hiding this comment.
LGTM! Just confirming that we do want this on every span, not just segment spans?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
sentry.replay_idas a span attribute on streamed spans via aprocessSpanhook on the Replay integration. This is expected as per https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/#common-attribute-keys and wasn't previously set, so replays could not be connected to their traces in the UI when span streaming is active.Fix lives in the replay integration to not impact bundle size for users who don't use session replays. However, since this is quite a small change with only a small bundle impact we can also discuss putting this in
captureSpanfor maintainability reasons (so we have more of the logic in a central place instead of cluttered all over).Currently this still doesn't work yet in the product. It seems that the UI relies on
replayIdinstead ofsentry.replay_id, butsentry.replay_idis the attribute we defined for SDKs (conventions, dev docs) so the fix will likely be to update this in the product (but will confirm with them before merging). No harm in already reviewing so we have it ready to go.Closes #20880