Handle complex RSE rendering in the uber SDF pipeline#186434
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enables SDF rendering for asymmetric rounded superellipses by transitioning from single-quadrant to per-quadrant parameter processing. Key changes include updating UberSDFParameters to store quadrant data in Vector4 types and rewriting the uber_sdf.frag shader to evaluate all four quadrants. Feedback highlights a critical bug where an uninitialized variable grad_norm is used in the shader, as well as opportunities to optimize performance by using split points for branching and removing the unused distanceToSegment function.
There was a problem hiding this comment.
Code Review
This pull request enables the rendering of asymmetric rounded superellipses via Signed Distance Fields (SDFs). The implementation refactors the UberSDF pipeline to store and process per-quadrant geometric parameters using Vector4 structures in both the C++ host code and the fragment shader. Feedback suggests unifying the component ordering of corner radii across different shape types to maintain consistency with the shader's quadrant indexing logic.
gaaclarke
left a comment
There was a problem hiding this comment.
Hey @walley892, the golden for impeller_Play_AiksTest_CanRenderAsymmetricRoundSuperellipses_MetalSDF doesn't look right https://flutter-gold.skia.org/search?issue=186434&crs=github&patchsets=6&corpus=flutter
|
Confirmed with steamboat willie that the goldens look good locally on his M1 and my M4. Investigating 
|
From the glsl perspective, yeah. the c++ is where the code bloat is mostly happening - split things out |
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM, there is just some minor formatting that needs to be fixed. I like us to make this lazy loaded, that can be a followup though. Nice work @walley892
|
autosubmit label was removed for flutter/flutter/186434, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
flutter/flutter@e70534d...b05a9d7 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from 47155534833e to d9d6b440c4e7 (1 revision) (flutter/flutter#187301) 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from f93ed13d77fb to 47155534833e (4 revisions) (flutter/flutter#187291) 2026-05-29 kevmoo@users.noreply.github.com [web_ui] Optimize skwasm text layout and path decoding to eliminate dynamic boxing churn under Wasm (flutter/flutter#186978) 2026-05-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SBpmmPxqx3lAvGojE... to jMR_VXQi07kAk8vbR... (flutter/flutter#187279) 2026-05-29 burak.karahan@mail.ru Remove Material import from sliver tree rendering test (flutter/flutter#187000) 2026-05-29 bdero@google.com [Impeller] Remove the y_coord_scale Y-flip plumbing (flutter/flutter#187224) 2026-05-29 31859944+LongCatIsLooong@users.noreply.github.com Add/remove overlay child RenderObject from the tree in `attach`/`detach` (flutter/flutter#186564) 2026-05-29 engine-flutter-autoroll@skia.org Roll Skia from fcfe5975c945 to f93ed13d77fb (4 revisions) (flutter/flutter#187273) 2026-05-28 evanwall@buffalo.edu Handle complex RSE rendering in the uber SDF pipeline (flutter/flutter#186434) 2026-05-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 082191101fcc to 683322426411 (2 revisions) (flutter/flutter#187270) 2026-05-28 mvincentong@gmail.com Clarify route transition animations (flutter/flutter#186552) 2026-05-28 116356835+AbdeMohlbi@users.noreply.github.com document that the default Key is null and explain proper usage in list diffing (flutter/flutter#185197) 2026-05-28 srawlins@google.com [flutter_tools] Use super parameters in missed spots (flutter/flutter#186197) 2026-05-28 mr_nadeem_iqbal@yahoo.com docs: Document MediaQueryData.alwaysUse24HourFormat on macOS, Windows, Linux, web (#160664) (flutter/flutter#186642) 2026-05-28 engine-flutter-autoroll@skia.org Roll Skia from 5493e4c144cd to fcfe5975c945 (3 revisions) (flutter/flutter#187256) 2026-05-28 30870216+gaaclarke@users.noreply.github.com Shares opengles golden context (flutter/flutter#187243) 2026-05-28 jason-simmons@users.noreply.github.com Update the Curl CIPD package in .ci.yaml to version 8.20.0 (flutter/flutter#187133) 2026-05-28 737941+loic-sharma@users.noreply.github.com Improve SizedBox's docs (flutter/flutter#187208) 2026-05-28 bdero@google.com [Impeller] Support instanced rendering across all backends (flutter/flutter#186653) 2026-05-28 43054281+camsim99@users.noreply.github.com [Android] Reset system UI visibility flags when setting edge-to-edge mode (flutter/flutter#187207) 2026-05-28 engine-flutter-autoroll@skia.org Roll Skia from a38708fb7926 to 5493e4c144cd (7 revisions) (flutter/flutter#187241) 2026-05-28 30870216+gaaclarke@users.noreply.github.com Turned on impeller by default on macos (flutter/flutter#186546) 2026-05-28 mvincentong@gmail.com Clarify lazy scroll extent docs (flutter/flutter#186864) 2026-05-28 mdebbar@google.com [web] Fix WebParagraph locales test (flutter/flutter#186813) 2026-05-28 engine-flutter-autoroll@skia.org Roll Packages from 4b424d7 to 10cbdc5 (3 revisions) (flutter/flutter#187238) 2026-05-28 engine-flutter-autoroll@skia.org Roll Dart SDK from f3db7b7d9801 to 082191101fcc (8 revisions) (flutter/flutter#187235) 2026-05-28 engine-flutter-autoroll@skia.org Roll Skia from 32acea791248 to a38708fb7926 (1 revision) (flutter/flutter#187221) 2026-05-28 bdero@google.com [Flutter GPU] Add r32Float and remove Apple-only XR pixel formats (flutter/flutter#187069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates the uber SDF shader pipeline to support complex RSEs with asymmetric corner radii.
This works by breaking the RSE into four quadrants, and evaluating them separately.
Separates the rendering paths for symmetric and asymmetric RSEs so symmetric RSEs don't need as much branching.
Also tucks the parameter unpacking into uber_sdf_contents.cc, because the canvas code was getting bloated.
Adds unit tests and a golden.
Will need to update malioc
Pre-launch Checklist
///).