Fix broken local paths in docs/engine/testing/Testing-the-engine.md #185701
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates documentation links in docs/engine/testing/Testing-the-engine.md by replacing relative paths with absolute paths. The review feedback highlights that these absolute paths will break when viewed on GitHub because they resolve relative to the domain root rather than the repository root. It is recommended to revert to relative paths to ensure link portability and correctness across different environments.
70056af to
8358bce
Compare
There was a problem hiding this comment.
Code Review
This pull request updates various file paths within the 'docs/engine/testing/Testing-the-engine.md' documentation to point to the engine source code. The reviewer identified that these relative paths are invalid in the context of the 'flutter/flutter' repository and suggested replacing them with absolute URLs to the 'flutter/engine' repository to ensure they remain functional.
|
I think links when viewed locally will be broken... but I don't have numbers on how often links are viewed locally or on github. |
When I preview the file with VSCode, these links resolve correctly. If there is a different way of viewing locally which has an issue, let's address in a followup. I'll merge for now. |
This file was moved from /engine/src to /docs/engine/, so let's update the paths to be relative to the repository root
8358bce to
38d762e
Compare
Fix broken local paths in docs/engine/testing/Testing-the-engine.md.
This file was moved from /engine/src/flutter/ to /docs/engine/ in #175195 but these local links were not updated. So let's update the paths to be relative to the repository root.
No issue since this is a trivial docs change
Pre-launch Checklist
///).