chore: move engine docs out of engine/ and into docs/#175195
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Code Review
This pull request moves engine-related documentation from the engine/ directory to a new docs/engine directory. This is a significant refactoring that involves renaming a large number of documentation files and updating links throughout the codebase to reflect their new locations. The changes primarily affect Markdown files, but also update links in source code comments and configuration files. My review identified one incorrect URL in a C++ source file comment which needs correction. The rest of the link updates appear to be correct and consistent with the file moves.
|
There are other files that need to be moved around a bit; the |
|
autosubmit label was removed for flutter/flutter/175195, because Pull request flutter/flutter/175195 is not in a mergeable state. |
They should not be included in engine build symantics
Moving docs to be co-located with other docs + updating links. This has the benefit of not including docs in engine content hash semantics.
flutter/flutter@8d0b31d...8f94cb0 2025-09-17 mohellebiabdessalem@gmail.com fix typo in comments to mention `settings.gradle/.kts` instead of `build.gradle/.kts` (flutter/flutter#175486) 2025-09-17 mohellebiabdessalem@gmail.com replace ` Charset.forName("UTF-8")` with `StandardCharsets.UTF_8` to address linter issues (flutter/flutter#175275) 2025-09-17 engine-flutter-autoroll@skia.org Roll Skia from 283a8ff3bca5 to a5a8f1df14bb (6 revisions) (flutter/flutter#175512) 2025-09-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 649eef6040a1 to 116f7fe72839 (3 revisions) (flutter/flutter#175474) 2025-09-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wzk_HjPLGu-mlg5hC... to 0_jKqLGnkILvQ5C8a... (flutter/flutter#175468) 2025-09-16 34871572+gmackall@users.noreply.github.com Sync 3.35.3 and 3.35.4 notes from stable to master (flutter/flutter#175461) 2025-09-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 700de52f29a9 to 649eef6040a1 (4 revisions) (flutter/flutter#175455) 2025-09-16 mohellebiabdessalem@gmail.com Update gradle_errors.dart to use constants defined in gradle_utils.dart (flutter/flutter#174760) 2025-09-16 mohellebiabdessalem@gmail.com Update gradle_utils.dart to use `constant` instead of `final` (flutter/flutter#175443) 2025-09-16 mohellebiabdessalem@gmail.com fix typo in test documentation (flutter/flutter#174292) 2025-09-16 1961493+harryterkelsen@users.noreply.github.com [benchmarks] Allow passing --local-web-sdk and --build-mode flags to benchmarks (flutter/flutter#175199) 2025-09-16 34871572+gmackall@users.noreply.github.com Roll pub packages and update lockfiles (flutter/flutter#175446) 2025-09-16 ryjohn@google.com [docs] Add initial version of Flutter AI rules (flutter/flutter#175011) 2025-09-16 mohellebiabdessalem@gmail.com Remove redundant `public` modifier for interface members in MouseCursorPlugin.java (flutter/flutter#175281) 2025-09-16 mohellebiabdessalem@gmail.com Remove the unnecessary semicolon at the end of the line in `ProcessTextPlugin.java` (flutter/flutter#175280) 2025-09-16 mohellebiabdessalem@gmail.com Remove unnecessary `toString()` call in `ImageReaderPlatformViewRenderTarget.java` (flutter/flutter#175286) 2025-09-16 mohellebiabdessalem@gmail.com Refactor `AccessibilityBridge.java` to address linter issues (flutter/flutter#175277) 2025-09-16 mohellebiabdessalem@gmail.com Replace `.size() == 0` with `isEmpty()` in `PlatformPlugin.java` (flutter/flutter#175285) 2025-09-16 dkwingsmt@users.noreply.github.com Allow Passing an AnimationController to CircularProgressIndicator and LinearProgressIndicator (flutter/flutter#174605) 2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 7d160bbf9403 to 283a8ff3bca5 (11 revisions) (flutter/flutter#175436) 2025-09-16 codefu@google.com chore: move engine docs out of engine/ and into docs/ (flutter/flutter#175195) 2025-09-16 jason-simmons@users.noreply.github.com [Impeller] Disable the render target cache when creating a snapshot in DlImageImpeller::MakeFromYUVTextures (flutter/flutter#174912) 2025-09-16 mohellebiabdessalem@gmail.com Remove redundant public modifier in `PlatformViewRenderTarget.java` (flutter/flutter#175284) 2025-09-16 jessiewong401@gmail.com Update NDK to The Latest Stable (flutter/flutter#175365) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Moving docs to be co-located with other docs + updating links. This has the benefit of not including docs in engine content hash semantics.
Moving docs to be co-located with other docs + updating links. This has the benefit of not including docs in engine content hash semantics.
Regression introduced in #175195
Regression introduced in #175195
Moving docs to be co-located with other docs + updating links. This has the benefit of not including docs in engine content hash semantics.
Regression introduced in flutter#175195
…lutter#185701) Fix broken local paths in docs/engine/testing/Testing-the-engine.md. This file was moved from /engine/src/flutter/ to /docs/engine/ in flutter#175195 but these local links were not updated. So let's update the paths to be relative to the repository root. No issue since this is a trivial docs change ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Moving docs to be co-located with other docs + updating links. This has the benefit of not including docs in engine content hash semantics.