Handle#6537 fifth grouped tests by ahmedsameha1 · Pull Request #183720 · flutter/flutter

ahmedsameha1 · 2026-03-16T04:57:19Z

This is my attempt to handle #6537 for the following widgets:
SingleChildScrollView
SizeChangedLayoutNotifier
WidgetInspector
Visibility
ShrinkWrappingViewport
ValueListenableBuilder
TweenAnimationBuilder
SlideTransition
MatrixTransition
ScaleTransition

gemini-code-assist

Code Review

This pull request adds widget tests for several widgets to ensure they don't crash when rendered in a zero-area container. The added tests are valuable for improving widget robustness. I've suggested a couple of minor changes to improve consistency across the new tests.

gemini-code-assist · 2026-03-16T04:59:20Z

+  testWidgets('ScaleTransition does not crash at zero', (
+    WidgetTester tester,
+  ) async {
+    final key = Key('ScaleTransition');
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: Center(
+          child: SizedBox.shrink(
+            child: example.ScaleTransitionExample(key: key),
+          ),
+        ),
+      ),
+    );
+    expect(tester.getSize(find.byKey(key)), Size.zero);
+  });


For consistency with other tests in this PR, the test name should be 'ScaleTransition does not crash at zero area'. Additionally, it's better to find the ScaleTransition widget by its type directly, rather than finding the example widget by a key. This makes the test more direct and consistent with the other transition tests.

testWidgets('ScaleTransition does not crash at zero area', ( WidgetTester tester, ) async { await tester.pumpWidget( Directionality( textDirection: TextDirection.ltr, child: Center( child: SizedBox.shrink( child: const example.ScaleTransitionExample(), ), ), ), ); expect(tester.getSize(find.byType(ScaleTransition)), Size.zero); });

I'm also curious. Is it because there's another ScaleTransition?

If I tried to find the widget by type, it finds too many.

gemini-code-assist · 2026-03-16T04:59:20Z

    );
  });
+
+  testWidgets('SlideTransition does not crash zero area', (


There's a small typo in the test description. For consistency with other tests, it should be '... does not crash at zero area'.

Suggested change

testWidgets('SlideTransition does not crash zero area', (

testWidgets('SlideTransition does not crash at zero area', (

dkwingsmt

LGTM

dkwingsmt · 2026-03-17T22:41:08Z

    expect(transform.transform[0], 0);
  });
+
+  testWidgets('ScaleTransition does not crash at zero', (


Suggested change

testWidgets('ScaleTransition does not crash at zero', (

testWidgets('ScaleTransition does not crash at zero area', (

dkwingsmt · 2026-03-17T22:41:47Z

+  testWidgets('ScaleTransition does not crash at zero', (
+    WidgetTester tester,
+  ) async {
+    final key = Key('ScaleTransition');
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: Center(
+          child: SizedBox.shrink(
+            child: example.ScaleTransitionExample(key: key),
+          ),
+        ),
+      ),
+    );
+    expect(tester.getSize(find.byKey(key)), Size.zero);
+  });


I'm also curious. Is it because there's another ScaleTransition?

victorsanni

0x0 tests should not live in examples/.

ahmedsameha1 · 2026-04-02T15:51:30Z

0x0 tests should not live in examples/.

I will work on this.

victorsanni

LGTM, but can you fix the failing tests?

…onment

Roll Flutter from 2ba5420a7049 to 1bdf4af29076 (43 revisions) flutter/flutter@2ba5420...1bdf4af 2026-06-05 engine-flutter-autoroll@skia.org Roll Packages from 03352b5 to 61bdbb4 (5 revisions) (flutter/flutter#187612) 2026-06-05 engine-flutter-autoroll@skia.org Roll Skia from 6e003d7f69c8 to a47a9a2c8ae5 (1 revision) (flutter/flutter#187610) 2026-06-05 engine-flutter-autoroll@skia.org Roll Dart SDK from aad8be4ce307 to 6a9a0efe66eb (10 revisions) (flutter/flutter#187609) 2026-06-05 engine-flutter-autoroll@skia.org Roll Skia from 494f1bf55f51 to 6e003d7f69c8 (2 revisions) (flutter/flutter#187607) 2026-06-05 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZE1Jy9CtVVi-tjBAE... to N_LiSaBSUsE2LDZgG... (flutter/flutter#187597) 2026-06-05 engine-flutter-autoroll@skia.org Roll Skia from 59556fdb8c33 to 494f1bf55f51 (2 revisions) (flutter/flutter#187596) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from 8eb107046fd5 to 59556fdb8c33 (1 revision) (flutter/flutter#187590) 2026-06-04 34871572+gmackall@users.noreply.github.com Remove `embedded_android_views_integration_test.dart` (flutter/flutter#187465) 2026-06-04 burak.karahan@mail.ru Remove Material imports from rendering editable tests (flutter/flutter#186951) 2026-06-04 jason-simmons@users.noreply.github.com [Impeller] Wait for the Vulkan device to become idle before destroying Vulkan objects in the AHBSwapchainImplVK destructor (flutter/flutter#187477) 2026-06-04 chris@bracken.jp [iOS] Eliminate unnecessary redeclaration of FlutterDisplayLink (flutter/flutter#187557) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from 928ded2a31af to 8eb107046fd5 (1 revision) (flutter/flutter#187583) 2026-06-04 34871572+gmackall@users.noreply.github.com Log stdout in adb.dart (flutter/flutter#187531) 2026-06-04 mvincentong@gmail.com Clarify RouterDelegate popRoute bubbling (flutter/flutter#186875) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from 928ded2a31af to 8eb107046fd5 (1 revision) (flutter/flutter#187584) 2026-06-04 1063596+reidbaker@users.noreply.github.com Add updating-android-sdk agent skill for rolling Android SDK in CIPD (flutter/flutter#187576) 2026-06-04 Rusino@users.noreply.github.com Fixing alignment issue (flutter/flutter#187518) 2026-06-04 brackenavaron@gmail.com [Material Cross Imports] Clean up Material Divider usages (flutter/flutter#187300) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from cecc0e0da9ae to 928ded2a31af (6 revisions) (flutter/flutter#187574) 2026-06-04 31859944+LongCatIsLooong@users.noreply.github.com Use swift demangle to verify internal Swift symbols (flutter/flutter#186835) 2026-06-04 1063596+reidbaker@users.noreply.github.com Add android 37 platform and build tools to script for android cipd bundle creation (flutter/flutter#187571) 2026-06-04 jason-simmons@users.noreply.github.com [Impeller] Increase the precision of the IPSampleWithTileModeOES coords parameter to match the input coordinates in the tiled_texture_fill_external shader (flutter/flutter#187545) 2026-06-04 engine-flutter-autoroll@skia.org Roll Packages from b11504f to 03352b5 (4 revisions) (flutter/flutter#187569) 2026-06-04 iinozemtsev@google.com Roll Dart SDK to Dart 3.13 beta2 (flutter/flutter#187555) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from 611e3f8ceb93 to cecc0e0da9ae (1 revision) (flutter/flutter#187562) 2026-06-04 6655696+guidezpl@users.noreply.github.com Add step to bootstrap Flutter tool in coverage workflow (flutter/flutter#187199) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from 4fdb859c8da7 to 611e3f8ceb93 (4 revisions) (flutter/flutter#187554) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from 0020aae33f63 to 4fdb859c8da7 (2 revisions) (flutter/flutter#187552) 2026-06-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ap7MhLX4TdpWRrLS_... to ZE1Jy9CtVVi-tjBAE... (flutter/flutter#187550) 2026-06-04 stuartmorgan@google.com Add vector_math to package issue template (flutter/flutter#187536) 2026-06-04 jason-simmons@users.noreply.github.com Manual roll Dart SDK from d39850bf4a01 to 3b70b98fa7c0 (flutter/flutter#187519) 2026-06-04 engine-flutter-autoroll@skia.org Roll Skia from d625048c853a to 0020aae33f63 (20 revisions) (flutter/flutter#187539) 2026-06-04 smille2003@yandex.ru [Impeller][Windows] fix black screen on OpenGL fallback (flutter/flutter#187288) 2026-06-04 97480502+b-luk@users.noreply.github.com Fix unintentionally joined path contours (flutter/flutter#187522) 2026-06-03 matt.boetger@gmail.com fix: resolve issue #177379 by using lazy buildDirectory.dir() API in build.gradle template (flutter/flutter#187127) 2026-06-03 34871572+gmackall@users.noreply.github.com Add a skill for flake analysis (flutter/flutter#187530) 2026-06-03 30870216+gaaclarke@users.noreply.github.com adds linux impeller project flag (flutter/flutter#186982) 2026-06-03 codedoctor@linwood.dev Add support for stylus buttons (flutter/flutter#183369) 2026-06-03 46920873+gabrimatic@users.noreply.github.com Prevent Cubic transform from looping on out-of-range input (flutter/flutter#185875) 2026-06-03 bdero@google.com [Impeller] Reland: Allow attaching specific texture mip levels and slices (flutter/flutter#187470) 2026-06-03 kjlubick@users.noreply.github.com [skia] Update image deserial proc (flutter/flutter#185041) 2026-06-03 112751483+shivanshu877@users.noreply.github.com docs: update Impeller advanced blend docs for framebuffer fetch (flutter/flutter#185457) 2026-06-03 ahmedsameha1@gmail.com Handle#6537 fifth grouped tests (flutter/flutter#183720) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 16, 2026

gemini-code-assist Bot reviewed Mar 16, 2026

View reviewed changes

ahmedsameha1 force-pushed the handle#6537-fifth-grouped-tests branch from b96b1a5 to 3a3c97b Compare March 16, 2026 05:05

Piinks requested review from dkwingsmt and victorsanni March 17, 2026 22:34

dkwingsmt previously approved these changes Mar 17, 2026

View reviewed changes

ahmedsameha1 dismissed dkwingsmt’s stale review via c51fc47 March 18, 2026 04:55

ahmedsameha1 force-pushed the handle#6537-fifth-grouped-tests branch from 3a3c97b to c51fc47 Compare March 18, 2026 04:55

dkwingsmt added the CICD Run CI/CD label Mar 18, 2026

dkwingsmt previously approved these changes Mar 18, 2026

View reviewed changes

victorsanni reviewed Mar 24, 2026

View reviewed changes

Comment thread examples/api/test/widgets/transitions/matrix_transition.0_test.dart Outdated

Comment thread packages/flutter/test/widgets/tween_animation_builder_test.dart Outdated

ahmedsameha1 dismissed dkwingsmt’s stale review via 4d1fc7a March 25, 2026 01:31

ahmedsameha1 force-pushed the handle#6537-fifth-grouped-tests branch from c51fc47 to 4d1fc7a Compare March 25, 2026 01:31

justinmc requested review from dkwingsmt and victorsanni March 31, 2026 22:11

victorsanni reviewed Apr 1, 2026

View reviewed changes

ahmedsameha1 force-pushed the handle#6537-fifth-grouped-tests branch from 4d1fc7a to de5d02f Compare April 12, 2026 05:59

github-actions Bot added CICD Run CI/CD and removed CICD Run CI/CD d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 12, 2026

ahmedsameha1 requested a review from victorsanni April 12, 2026 05:59

victorsanni reviewed Apr 15, 2026

View reviewed changes

github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026

justinmc requested a review from victorsanni April 21, 2026 22:27

ahmedsameha1 added 10 commits June 3, 2026 10:43

Make sure that a SingleChildScrollView doesn't crash in 0x0 environment

5314e94

Make sure that a SizeChangedLayoutNotifier doesn't crash in 0x0 envir…

d1b410a

…onment

Make sure that a WidgetInspector doesn't crash in 0x0 environment

81139dd

Make sure that a Visibility doesn't crash in 0x0 environment

a26901a

Make sure that a ShrinkWrappingViewport doesn't crash in 0x0 environment

36ed280

Make sure that a ValueListenableBuilder doesn't crash in 0x0 environment

ec7b5da

Make sure that a TweenAnimationBuilder doesn't crash in 0x0 environment

c6d498e

Setting the physicalSize to Size.zero instead of using SizedBox.shrink()

3d3fc25

Fix a leak in a zero area test

7e9643b

Fix leaks in zero area tests

a0f7124

Piinks force-pushed the handle#6537-fifth-grouped-tests branch from f85a3ed to a0f7124 Compare June 3, 2026 15:43

github-actions Bot removed the CICD Run CI/CD label Jun 3, 2026

Piinks added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 3, 2026

auto-submit Bot added this pull request to the merge queue Jun 3, 2026

Merged via the queue into flutter:master with commit aaa6f05 Jun 3, 2026
94 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle#6537 fifth grouped tests#183720

Handle#6537 fifth grouped tests#183720
auto-submit[bot] merged 13 commits into
flutter:masterfrom
ahmedsameha1:handle#6537-fifth-grouped-tests

ahmedsameha1 commented Mar 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 16, 2026

Uh oh!

dkwingsmt Mar 17, 2026

Uh oh!

ahmedsameha1 Mar 18, 2026

Uh oh!

gemini-code-assist Bot Mar 16, 2026

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Mar 17, 2026

Uh oh!

dkwingsmt Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

victorsanni left a comment

Uh oh!

ahmedsameha1 commented Apr 2, 2026

Uh oh!

victorsanni left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	testWidgets('SlideTransition does not crash zero area', (
	testWidgets('SlideTransition does not crash at zero area', (

	testWidgets('ScaleTransition does not crash at zero', (
	testWidgets('ScaleTransition does not crash at zero area', (

Conversation

ahmedsameha1 commented Mar 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedsameha1 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedsameha1 commented Apr 2, 2026

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants