[iOS] Eliminate unnecessary redeclaration of FlutterDisplayLink#187557
Conversation
Since FlutterDisplayLink is exported in the Swift module header, we can use it directly. No changes to desks since this is a simple cleanup that introduces no semantic changes. Issue: flutter#112232 Issue: flutter#181684
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates FlutterMetalLayer.mm by importing the InternalFlutterSwift.h header and removing the redundant forward declaration of the FlutterDisplayLinkManager interface. There are no review comments, and I have no feedback to provide.
|
test-exempt: code refactor with no semantic change |
Since FlutterDisplayLink is exported in the Swift module header, and that code has been pushed deeper in the dependency tree (plus the method in question made public), we can now use it directly.
No changes to desks since this is a simple cleanup that introduces no semantic changes.
Issue: #112232
Issue: #181684
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.