This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Support highlighting the full expression#3205
Merged
Merged
Conversation
b684c36 to
9fac797
Compare
Codecov Report
@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
- Coverage 47.94% 47.39% -0.55%
==========================================
Files 98 97 -1
Lines 4063 4019 -44
Branches 838 827 -11
==========================================
- Hits 1948 1905 -43
+ Misses 2115 2114 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3205 +/- ##
=========================================
- Coverage 47.92% 47.9% -0.02%
=========================================
Files 98 98
Lines 4063 4064 +1
Branches 833 835 +2
=========================================
Hits 1947 1947
- Misses 2116 2117 +1
Continue to review full report at Codecov.
|
03164bb to
52063e5
Compare
Contributor
|
@jasonLaster @bomsy can you check if the updated test snapshot is correct? |
Contributor
|
(closed by accident) |
Contributor
|
@codehag I just tested this and all the tests complete nicely on my machine 👍 |
Contributor
|
@aklt Super! |
1280e40 to
de7fdeb
Compare
* highlight pause expressions * add test
de7fdeb to
2f589fb
Compare
2f589fb to
45f07dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3109
WIP - Highlight the entire expression on hover