This repository was archived by the owner on Jan 11, 2023. It is now read-only.
highlight pause expressions#3195
Merged
jasonLaster merged 2 commits intoJun 22, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3195 +/- ##
=========================================
- Coverage 47.94% 47.9% -0.04%
=========================================
Files 98 98
Lines 4063 4066 +3
Branches 838 839 +1
=========================================
Hits 1948 1948
- Misses 2115 2118 +3
Continue to review full report at Codecov.
|
wldcordeiro
reviewed
Jun 22, 2017
| .new-debug-line .CodeMirror-line { | ||
| background-color: var(--debug-line-background) !important; | ||
| background-color: transparent !important; | ||
| outline: var(--debug-line-border) solid 1px; |
Contributor
There was a problem hiding this comment.
Maybe move this to the .debug-expression? I think it'd look a little nicer rather than the whole line having the outline.
Contributor
Author
There was a problem hiding this comment.
Hmm - happy to try. I kinda like framing the line and highlighting the relevant section, but I bet there's more we can do too
wldcordeiro
approved these changes
Jun 22, 2017
Contributor
wldcordeiro
left a comment
There was a problem hiding this comment.
Just an idea/suggestion but I think it's an improvement either way. 👍
6b58fef to
671b070
Compare
671b070 to
8a3431c
Compare
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jun 22, 2017
This reverts commit 9b77377.
jasonLaster
added a commit
that referenced
this pull request
Jun 22, 2017
* 6-22 release * fix toggling function search * Revert "highlight pause expressions (#3195)"
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jun 22, 2017
* highlight pause expressions * add test
jasonLaster
pushed a commit
to bomsy/debugger.html
that referenced
this pull request
Jun 23, 2017
* highlight pause expressions * add test
jasonLaster
pushed a commit
to bomsy/debugger.html
that referenced
this pull request
Jun 23, 2017
* highlight pause expressions * add test
jasonLaster
pushed a commit
that referenced
this pull request
Jun 23, 2017
* highlight pause expressions (#3195)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This updates our debug line highlighter so that it starts at the column we're paused at. This is more informative because we're often not paused at the beginning of a line.
Test Plan
I'd like to update
editor-highlightScreenshots/Videos (OPTIONAL)
after
before