This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix for the last closed tab not getting persisted#2721
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 57.9% 58.65% +0.75%
==========================================
Files 61 63 +2
Lines 2264 2368 +104
Branches 470 487 +17
==========================================
+ Hits 1311 1389 +78
- Misses 953 979 +26
Continue to review full report at Codecov.
|
Contributor
|
@bomsy looks great. Mind encoding those steps in a test :)
|
jasonLaster
reviewed
Apr 24, 2017
|
|
||
| case "CLOSE_TAB": | ||
| availableTabs = removeSourceFromTabList(state.tabs, action.url); | ||
| location = { sourceId: getNewSelectedSourceId(state, availableTabs) }; |
Contributor
There was a problem hiding this comment.
hmm, we might want the line number, no?
Contributor
Author
There was a problem hiding this comment.
Actually we would have a line number because we just closed a tab.
Contributor
Author
|
working on tests now! |
Contributor
|
@bomsy I see some unit test errors and flow type errors |
Contributor
Author
|
yeah...still wip, i just did a quick push so i could work off another laptop |
…ingSelectedlocation object, add a getSourceUrlbyId function
jasonLaster
approved these changes
May 10, 2017
| it("tabs", async () => await tabs(ctx)); | ||
| xit("tabs - add tabs", async () => await tabs.addTabs(ctx)); | ||
| xit("tabs - reload with tabs", async () => await tabs.reloadWithTabs(ctx)); | ||
| xit( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2615 and maybe #2638
Summary of Changes
pendingSelectedLocationis updatedTest Plan
Tell us a little a bit about how you tested your patch.
Example test plan:
Screenshots/Videos