Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Tabs] tabs are no longer persisted on refresh #2638

@jasonLaster

Description

@jasonLaster

STR:

  1. go to http://devtools-html.github.io/debugger-examples/examples/todomvc/
  2. select two sources
  3. refresh the debugger

AR: you see the selected source
ER: you see both tabs

here is a test that demonstrates the regression:

One way to work on this is to go to localhost:8000/integration and fix the tabs test:

diff --git a/src/test/integration/runner.js b/src/test/integration/runner.js
index 46f07f0..e2fff6a 100644
--- a/src/test/integration/runner.js
+++ b/src/test/integration/runner.js
@@ -153,7 +153,7 @@ describe("Tests", () => {
     await sourceMapsBogus(ctx);
   });

-  it("tabs", async function() {
+  it.only("tabs", async function() {
     await tabs(ctx);
   });
 });
diff --git a/src/test/integration/tests/tabs.js b/src/test/integration/tests/tabs.js
index cd35d34..b1a28db 100644
--- a/src/test/integration/tests/tabs.js
+++ b/src/test/integration/tests/tabs.js
@@ -21,6 +21,5 @@ module.exports = async function(ctx) {
   await reload(dbg, "simple2");
   await waitForDispatch(dbg, "LOAD_SOURCE_TEXT");

-  // NOTE: when we fix persisted tabs we should have two
-  expect(countTabs(dbg)).to.equal(1);
+  expect(countTabs(dbg)).to.equal(2);
 };

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions