Skip to content

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SelaseKay merged 8 commits into from
Feb 5, 2026
Merged

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a184158
Add modifiers to the reference
deepak786 Jan 27, 2026
edb44b1
Adjustments
deepak786 Jan 27, 2026
9ab032d
Run melos format ci
deepak786 Jan 28, 2026
d90c110
Revert "Run melos format ci"
deepak786 Jan 28, 2026
9c633f3
Merge branch 'firebase:main' into fix_keep_synced_android
deepak786 Jan 29, 2026
67e3afd
Add tests
deepak786 Feb 3, 2026
c0c94b5
Add missing "key" in startAt
deepak786 Feb 3, 2026
711af9c
Skip test on web
deepak786 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing "key" in startAt
  • Loading branch information
@deepak786
deepak786 committed Feb 3, 2026
commit c0c94b55e2373bb3e2c73f06cb276e3fa6da17e5
16 changes: 8 additions & 8 deletions ...se/android/src/main/kotlin/io/flutter/plugins/firebase/database/FirebaseDatabasePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,11 +881,11 @@ class FirebaseDatabasePlugin :
break
}
val value = modifier["value"]
val key = modifier["key"] as String?
query = when (value) {
is String -> query.startAt(value)
is Number -> query.startAt(value.toDouble())
is Boolean -> query.startAt(value)
else -> query.startAt(value.toString())
is Boolean -> if (key == null) query.startAt(value) else query.startAt(value, key)
is Number -> if (key == null) query.startAt(value.toDouble()) else query.startAt(value.toDouble(), key)
else -> if (key == null) query.startAt(value.toString()) else query.startAt(value.toString(), key)
}
}
"startAfter" -> {
Expand Down Expand Up @@ -1011,11 +1011,11 @@ class FirebaseDatabasePlugin :
break
}
val value = modifier["value"]
val key = modifier["key"] as String?
query = when (value) {
is String -> query.startAt(value)
is Number -> query.startAt(value.toDouble())
is Boolean -> query.startAt(value)
else -> query.startAt(value.toString())
is Boolean -> if (key == null) query.startAt(value) else query.startAt(value, key)
is Number -> if (key == null) query.startAt(value.toDouble()) else query.startAt(value.toDouble(), key)
else -> if (key == null) query.startAt(value.toString()) else query.startAt(value.toString(), key)
}
}
"startAfter" -> {
Expand Down
Loading