Skip to content

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SelaseKay merged 8 commits into from
Feb 5, 2026
Merged

fix(firebase_database): Add modifiers to keepSynced ref in android #17978

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a184158
Add modifiers to the reference
deepak786 Jan 27, 2026
edb44b1
Adjustments
deepak786 Jan 27, 2026
9ab032d
Run melos format ci
deepak786 Jan 28, 2026
d90c110
Revert "Run melos format ci"
deepak786 Jan 28, 2026
9c633f3
Merge branch 'firebase:main' into fix_keep_synced_android
deepak786 Jan 29, 2026
67e3afd
Add tests
deepak786 Feb 3, 2026
c0c94b5
Add missing "key" in startAt
deepak786 Feb 3, 2026
711af9c
Skip test on web
deepak786 Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run melos format ci
  • Loading branch information
@deepak786
deepak786 committed Jan 28, 2026
commit 9ab032d7af1fa25b7966b8b4bbef063b09a06f4d
54 changes: 30 additions & 24 deletions tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,32 +129,37 @@ void main() {
await subscription.cancel();
});

test('fires once on first initialization of FirebaseAuth', () async {
// Fixes a very specific bug: https://github.com/firebase/flutterfire/issues/3628
// If the first initialization of FirebaseAuth involves the listeners userChanges() or idTokenChanges()
// the user will receive two events. Why? The native SDK listener will always fire an event upon initial
// listen. FirebaseAuth also sends an initial synthetic event. We send a synthetic event because, ordinarily, the user will
// not use a listener as the first occurrence of FirebaseAuth. We, therefore, mimic native behavior by sending an
// event. This test proves the logic of PR: https://github.com/firebase/flutterfire/pull/6560

// Requires a fresh app.
FirebaseApp second = await Firebase.initializeApp(
name: 'test-init',
options: DefaultFirebaseOptions.currentPlatform,
);
test(
'fires once on first initialization of FirebaseAuth',
() async {
// Fixes a very specific bug: https://github.com/firebase/flutterfire/issues/3628
// If the first initialization of FirebaseAuth involves the listeners userChanges() or idTokenChanges()
// the user will receive two events. Why? The native SDK listener will always fire an event upon initial
// listen. FirebaseAuth also sends an initial synthetic event. We send a synthetic event because, ordinarily, the user will
// not use a listener as the first occurrence of FirebaseAuth. We, therefore, mimic native behavior by sending an
// event. This test proves the logic of PR: https://github.com/firebase/flutterfire/pull/6560

// Requires a fresh app.
FirebaseApp second = await Firebase.initializeApp(
name: 'test-init',
options: DefaultFirebaseOptions.currentPlatform,
);

Stream<User?> stream =
FirebaseAuth.instanceFor(app: second).userChanges();
Stream<User?> stream =
FirebaseAuth.instanceFor(app: second).userChanges();

subscription = stream.listen(
expectAsync1(
(User? user) {},
reason: 'Stream should only call once',
),
);
subscription = stream.listen(
expectAsync1(
(User? user) {},
reason: 'Stream should only call once',
),
);

await Future.delayed(const Duration(seconds: 2));
}, skip: defaultTargetPlatform == TargetPlatform.macOS || defaultTargetPlatform == TargetPlatform.windows,);
await Future.delayed(const Duration(seconds: 2));
},
skip: defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows,
);

test(
'calls callback with the current user and when user state changes',
Expand Down Expand Up @@ -868,7 +873,8 @@ void main() {
}
});
},
skip: defaultTargetPlatform == TargetPlatform.macOS || defaultTargetPlatform == TargetPlatform.windows,
skip: defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows,
);

group(
Expand Down
29 changes: 15 additions & 14 deletions tests/integration_test/firebase_crashlytics/firebase_crashlytics_e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,24 +104,25 @@ void main() {
test(
'should have consistent error reason format',
() async {
const eventChannel = EventChannel('plugins.flutter.io/firebase_crashlytics_test_stream');
final eventStream = eventChannel.receiveBroadcastStream();
const eventChannel = EventChannel(
'plugins.flutter.io/firebase_crashlytics_test_stream');
final eventStream = eventChannel.receiveBroadcastStream();

final completer = Completer<String>();
final completer = Completer<String>();

final subscription = eventStream.listen((event) {
completer.complete(event.toString());
});
final subscription = eventStream.listen((event) {
completer.complete(event.toString());
});

await FirebaseCrashlytics.instance.recordError(
'foo exception',
StackTrace.fromString('during testing'),
reason: 'foo reason',
);
await FirebaseCrashlytics.instance.recordError(
'foo exception',
StackTrace.fromString('during testing'),
reason: 'foo reason',
);

final event = await completer.future;
expect(event, 'thrown foo reason');
await subscription.cancel();
final event = await completer.future;
expect(event, 'thrown foo reason');
await subscription.cancel();
},
skip: kIsWeb || defaultTargetPlatform == TargetPlatform.macOS,
);
Expand Down
18 changes: 8 additions & 10 deletions tests/integration_test/firebase_storage/task_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,10 @@ void setupTaskTests() {
retry: 3,
// TODO(russellwheatley): Windows works on example app, but fails on tests.
// Clue is in bytesTransferred + totalBytes which both equal: -3617008641903833651
skip: !kIsWeb && (
defaultTargetPlatform == TargetPlatform.windows ||
defaultTargetPlatform == TargetPlatform.android ||
defaultTargetPlatform == TargetPlatform.macOS
),
skip: !kIsWeb &&
(defaultTargetPlatform == TargetPlatform.windows ||
defaultTargetPlatform == TargetPlatform.android ||
defaultTargetPlatform == TargetPlatform.macOS),
);

// TODO(Salakar): Test is flaky on CI - needs investigating ('[firebase_storage/unknown] An unknown error occurred, please check the server response.')
Expand All @@ -127,11 +126,10 @@ void setupTaskTests() {
// This task is flaky on mac, skip for now.
// TODO(russellwheatley): Windows works on example app, but fails on tests.
// Clue is in bytesTransferred + totalBytes which both equal: -3617008641903833651
skip: !kIsWeb && (
defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows ||
defaultTargetPlatform == TargetPlatform.android
),
skip: !kIsWeb &&
(defaultTargetPlatform == TargetPlatform.macOS ||
defaultTargetPlatform == TargetPlatform.windows ||
defaultTargetPlatform == TargetPlatform.android),
);

test(
Expand Down