Make constructors in Parameter trait fallible#161
Merged
Conversation
prehner
approved these changes
Jul 3, 2023
Contributor
|
Since these are breaking changes, it should be merged into development rather than main. |
Co-authored-by: Philipp Rehner <69816385+prehner@users.noreply.github.com>
bbbursik
pushed a commit
to bbbursik/feos
that referenced
this pull request
Oct 17, 2023
* Make constructors in Parameter trait fallible * Update changelogs * Update CHANGELOG.md Co-authored-by: Philipp Rehner <69816385+prehner@users.noreply.github.com> --------- Co-authored-by: Philipp Rehner <69816385+prehner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes return types for constructor methods of
Parameterto results. This is useful for parameters that contain assertions or have multiple, incompatible variants. Existing assertions/unwraps in implemented parameters have not been changed in this PR.Since
Parameter::subsetis called on parameters that are usually created via the (now fallible) constructors, the method still returns the parameters without a results to keep the interfaces for property calculations clean. Addedpanicsection to the doc strings.