Support for second order Feynman-Hibbs corrections using the SAFT-VRQ Mie EOS#160
Merged
g-bauer merged 8 commits intofeos-org:mainfrom Jul 3, 2023
Merged
Support for second order Feynman-Hibbs corrections using the SAFT-VRQ Mie EOS#160g-bauer merged 8 commits intofeos-org:mainfrom
g-bauer merged 8 commits intofeos-org:mainfrom
Conversation
Contributor
morteham
commented
Jun 11, 2023
- Added support for FH0 and FH2
- Tested mixtures with FH2
- Use Feynman-Hibbs order stored in SaftVRQMieParameters
- Corrected pyhton interface
- Corrected parameter paths
- Added test case for FH2
Contributor
|
Morten thank you very much for the PR. I added another PR that enables parameter construction to be fallible (#161) and rebased your implementations. |
Contributor
Author
|
Great Gernot! Glad to help. |
… as implicit discriminants), implemented TryFrom<usize>
prehner
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.