Skip to content

adapters: serialize Avro ubigint as string #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiasongh wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

adapters: serialize Avro ubigint as string #6719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions crates/adapters/src/format/avro/serializer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,7 @@ impl<'a> Serializer for AvroSchemaSerializer<'a> {
serialize_maybe_optional(self.schema, |schema| match schema {
AvroSchema::Long if v < i64::MAX as u64 => Ok(AvroValue::Long(v as i64)),
AvroSchema::Long => Err(AvroSerializerError::out_of_bounds(&v, "u64", schema)),
AvroSchema::String => Ok(AvroValue::String(v.to_string())),
AvroSchema::TimeMicros => Ok(AvroValue::TimeMicros(v as i64)),
AvroSchema::TimeMillis => Ok(AvroValue::TimeMillis((v / 1000) as i32)),
_ => Err(AvroSerializerError::incompatible("u64", schema)),
Expand Down Expand Up @@ -880,6 +881,23 @@ mod test {
]
}"#;

#[derive(Serialize)]
struct TestUBigInt {
value: u64,
}

serialize_table_record!(TestUBigInt[1] {
value["value"]: u64
});

const SCHEMA_UBIGINT: &str = r#"{
"type": "record",
"name": "UBigInt",
"fields": [
{ "name": "value", "type": "string" }
]
}"#;

macro_rules! serializer_test {
($schema: expr_2021, $record: ident, $avro: ident) => {
let schema = serde_json::Value::from_str($schema).unwrap();
Expand Down Expand Up @@ -1060,4 +1078,15 @@ mod test {
avro_numeric_1_optional
);
}

#[test]
fn test_avro_serializer_ubigint() {
let record = TestUBigInt { value: u64::MAX };
let expected = AvroValue::Record(vec![(
"value".to_string(),
AvroValue::String(u64::MAX.to_string()),
)]);

serializer_test!(SCHEMA_UBIGINT, record, expected);
}
}