adapters: serialize Avro ubigint as string#6719
Open
xiasongh wants to merge 1 commit into
Open
Conversation
ryzhyk
approved these changes
Jul 24, 2026
mythical-fred
approved these changes
Jul 24, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Preserves full u64 range by falling through to AvroSchema::String when the schema declares string — the existing AvroSchema::Long path already errors above i64::MAX, so this is the natural escape hatch. Test pins u64::MAX. Fine.
APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow
u64to be serialized as string, which is also the avro datatype feldera generates foru64