Skip to content

adapters: validate Avro map key type #6717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiasongh wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

adapters: validate Avro map key type #6717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion crates/adapters/src/format/avro/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ impl AvroSchemaBuilder {
return Err("not implemented: Avro encoding for user-defined SQL types".to_string());
}
SqlType::Map => {
let key_type = column_type.value.as_ref().ok_or(
let key_type = column_type.key.as_ref().ok_or(
"internal error: relation schema contains a map field, with a missing key type",
)?;
if !key_type.typ.is_string() {
Expand Down Expand Up @@ -752,4 +752,17 @@ mod test {
);
}
}

#[test]
fn map_schema_uses_key_type() {
let builder = AvroSchemaBuilder::new();
let valid = ColumnType::map(false, ColumnType::varchar(false), ColumnType::bigint(false));
builder.column_type_to_avro_schema_inner(&valid).unwrap();

let invalid = ColumnType::map(false, ColumnType::int(false), ColumnType::varchar(false));
let error = builder
.column_type_to_avro_schema_inner(&invalid)
.unwrap_err();
assert!(error.contains("Avro only allows string keys"));
}
}