adapters: validate Avro map key type#6717
Open
xiasongh wants to merge 1 commit into
Open
Conversation
mihaibudiu
approved these changes
Jul 24, 2026
mihaibudiu
enabled auto-merge
July 24, 2026 03:20
mythical-fred
approved these changes
Jul 24, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Real bug fix. The previous code fetched column_type.value and then checked key_type.typ.is_string() — i.e. validating the value type against the "keys must be string" rule, effectively ignoring the actual key type. Switching to column_type.key restores the intended invariant. Test covers both the happy path and the non-string-key rejection.
APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code was trying to validate key but was validating value instead