[CI] Do not fail test test_upgrade_from_local_checkpoint if Rust cannot be built; it may be impossible to build with the previous version of the libraries#6706
Queued
mihaibudiu wants to merge 1 commit into
Conversation
mihaibudiu
enabled auto-merge
July 23, 2026 00:58
test_upgrade_from_local_checkpoint if Rust cannot be built; it may be impossible to build with the previous version of the libraries
gz
approved these changes
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
…ot be built; it may be impossible to build with the previous version of the libraries Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
enabled auto-merge
July 23, 2026 01:54
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 23, 2026
mythical-fred
approved these changes
Jul 23, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Reasonable escape hatch — old runtime images can drop off the network / become unbuildable, and hard-failing the whole test suite over that would just create noise. warnings.warn keeps the skip visible in CI output. "RustError" string match is loose but consistent with how the rest of test_checkpoint_runtime_upgrade.py inspects RuntimeError text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6705