Skip to content

[dbsp] Don't issue warning for pidlock file. #6633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blp merged 1 commit into from
Jul 15, 2026
Merged

[dbsp] Don't issue warning for pidlock file. #6633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/dbsp/src/circuit/checkpointer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
//! Logic to manage persistent checkpoints for a circuit.

use crate::dynamic::{self, data::DataTyped};
use crate::storage::dirlock::LockedDirectory;
use crate::storage::file::SerializerInner;
use crate::{Error, NumEntries, TypedBox};
use enum_map::{Enum, EnumMap};
Expand Down Expand Up @@ -120,6 +121,7 @@ impl Checkpointer {
in_use_paths.insert(format!("{}.mut", STATUS_FILE).into(), SmallVec::new());
in_use_paths.insert(DATAFUSION_TEMP_DIR.into(), SmallVec::new());
in_use_paths.insert(ACTIVATION_MARKER_FILE.into(), SmallVec::new());
in_use_paths.insert(LockedDirectory::LOCKFILE_NAME.into(), SmallVec::new());
for (checkpoint_index, cpm) in self.checkpoint_list.iter().enumerate() {
in_use_paths
.entry(cpm.uuid.to_string().into())
Expand Down
2 changes: 1 addition & 1 deletion crates/dbsp/src/storage/dirlock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ fn get_lock(file: &File) -> Result<Option<u32>, IoError> {
}

impl LockedDirectory {
const LOCKFILE_NAME: &'static str = "feldera.pidlock";
pub const LOCKFILE_NAME: &'static str = "feldera.pidlock";

/// Attempts to create a new pidfile in the `base_path` directory, returning
/// an error if the file was already created by a different process (and
Expand Down
Loading