Conversation
This suppresses a warning of the form
```
INFO dbsp::circuit::checkpointer: Keeping unexpected File { size: 0 } feldera.pidlock
```
when a pipeline restarts.
Tested manually by starting a pipeline with nonempty storage with and
without this commit.
Fixes: feldera/cloud#1726
Signed-off-by: Ben Pfaff <blp@feldera.com>
mihaibudiu
approved these changes
Jul 14, 2026
mythical-fred
approved these changes
Jul 15, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Trivial and correct: the pidlock file is expected in the storage dir, so it belongs in the in_use_paths allowlist alongside the other well-known bookkeeping files. Making LOCKFILE_NAME pub is the minimum-surface way to share the constant between dirlock and checkpointer. Signed-off, no AI trailers. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suppresses a warning of the form
when a pipeline restarts.
Tested manually by starting a pipeline with nonempty storage with and without this commit.
Fixes: https://github.com/feldera/cloud/issues/1726