Skip to content

Feathr UI: Display feature key and transform expression in feature detail pages#262

Merged
xiaoyongzhu merged 2 commits into
feathr-ai:mainfrom
blrchen:blair/ui-transformation
May 18, 2022
Merged

Feathr UI: Display feature key and transform expression in feature detail pages#262
xiaoyongzhu merged 2 commits into
feathr-ai:mainfrom
blrchen:blair/ui-transformation

Conversation

@blrchen

@blrchen blrchen commented May 16, 2022

Copy link
Copy Markdown
Collaborator

This PRs update feature detail ui page to display key and transform expression information.

Linked issue: #272

Staging site: https://brave-moss-045d2ce00.1.azurestaticapps.net

@hangfei

hangfei commented May 17, 2022

Copy link
Copy Markdown
Collaborator

No need to display other operators for non-swa feautures:

image

@hangfei

hangfei commented May 17, 2022

Copy link
Copy Markdown
Collaborator

There are both transform_expr and def_expr. This is confusing to understand.

Uploading image.png…

@hangfei

hangfei commented May 17, 2022

Copy link
Copy Markdown
Collaborator

image

@xiaoyongzhu xiaoyongzhu self-requested a review May 18, 2022 03:16
@xiaoyongzhu xiaoyongzhu merged commit 94c7a8b into feathr-ai:main May 18, 2022
@blrchen blrchen deleted the blair/ui-transformation branch May 18, 2022 03:33
bozhonghu pushed a commit that referenced this pull request Jun 1, 2022
* main: (30 commits)
  Yihui/moderate registration conflict (#304)
  Update homepage (#310)
  Add extensible extractor APIs (#302)
  Remove Java and JS from Code Scanning
  Create codeql-analysis.yml
  [feathr] Add API to materialize features to offline store (#294)
  Improve error message when path is not supported (#257)
  Add tech talk slides for Feathr (#296)
  Update README.md
  Add milestone link (#286)
  Fix millisecond timestamp handling (#288)
  Consolidating CI pipelines (#280)
  Fixed dependecy problem of pretty print utils (#273)
  Fixing a broken link in README.md (#277)
  Fix test failure (#276)
  Added feature validation (#258)
  Feathr UI: Display feature key and transform expression in feature detail pages (#262)
  Feathr UI: enable multiple tenant auth (#266)
  Reduce feathr web api docker image build time (#261)
  Pretty-print the features produced by buildFeatures  (#214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants