Skip to content

Improve error message when path is not supported#257

Merged
xiaoyongzhu merged 10 commits into
mainfrom
xiaoyzhu/click_bug
May 25, 2022
Merged

Improve error message when path is not supported#257
xiaoyongzhu merged 10 commits into
mainfrom
xiaoyzhu/click_bug

Conversation

@xiaoyongzhu

@xiaoyongzhu xiaoyongzhu commented May 15, 2022

Copy link
Copy Markdown
Member

There are cases where customers might put wasb/s3/etc. paths in databricks and wish Feathr can download those file and upload them to databricks. This is not supported by design, so adding warning & error message for that.

@hangfei

hangfei commented May 17, 2022

Copy link
Copy Markdown
Collaborator

add pr description

hangfei
hangfei previously approved these changes May 17, 2022
This reverts commit 400d230.
@xiaoyongzhu xiaoyongzhu requested a review from jaymo001 May 19, 2022 02:56
Comment thread feathr_project/feathr/_databricks_submission.py Outdated
@xiaoyongzhu xiaoyongzhu requested review from blrchen and hangfei May 23, 2022 17:45
@xiaoyongzhu xiaoyongzhu merged commit 5a7bebc into main May 25, 2022
@xiaoyongzhu xiaoyongzhu deleted the xiaoyzhu/click_bug branch May 25, 2022 17:56
bozhonghu pushed a commit that referenced this pull request Jun 1, 2022
* main: (30 commits)
  Yihui/moderate registration conflict (#304)
  Update homepage (#310)
  Add extensible extractor APIs (#302)
  Remove Java and JS from Code Scanning
  Create codeql-analysis.yml
  [feathr] Add API to materialize features to offline store (#294)
  Improve error message when path is not supported (#257)
  Add tech talk slides for Feathr (#296)
  Update README.md
  Add milestone link (#286)
  Fix millisecond timestamp handling (#288)
  Consolidating CI pipelines (#280)
  Fixed dependecy problem of pretty print utils (#273)
  Fixing a broken link in README.md (#277)
  Fix test failure (#276)
  Added feature validation (#258)
  Feathr UI: Display feature key and transform expression in feature detail pages (#262)
  Feathr UI: enable multiple tenant auth (#266)
  Reduce feathr web api docker image build time (#261)
  Pretty-print the features produced by buildFeatures  (#214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants