Skip to content

fix(schema): result resolver correctly resolves paginated find result #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Apr 11, 2022
Merged

fix(schema): result resolver correctly resolves paginated find result #2594

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505b082
fix result resolver if result contains a paginated result object inst…
idaho Apr 7, 2022
864c76d
add tests to test result resolving get and find with paginated result
idaho Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix result resolver if result contains a paginated result object inst… 
…ead of only an array
  • Loading branch information
@idaho
idaho committed Apr 7, 2022
commit 505b0823269eb1039d329626e6dfac849e134d4d
18 changes: 10 additions & 8 deletions packages/schema/src/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,18 @@ export const resolveResult = <T> (resolver: Resolver<T, HookContext>) =>

const ctx = getContext(context);
const status = context.params.resolve;
const data = context.method === 'find' && context.result.data
? context.result.data
: context.result;

if (Array.isArray(data)) {
context.result = await Promise.all(data.map(current =>
resolver.resolve(current, ctx, status)
));
const isPaginated = context.method === 'find' && context.result.data;
const data = isPaginated ? context.result.data : context.result;

const result = Array.isArray(data) ?
await Promise.all(data.map(async current => resolver.resolve(current, ctx, status))) :
await resolver.resolve(data, ctx, status);

if (isPaginated) {
context.result.data = result;
} else {
context.result = await resolver.resolve(data, ctx, status);
context.result = result;
}
};

Expand Down