fix(schema): result resolver correctly resolves paginated find result#2594
Merged
daffl merged 2 commits intofeathersjs:dovefrom Apr 11, 2022
Merged
fix(schema): result resolver correctly resolves paginated find result#2594daffl merged 2 commits intofeathersjs:dovefrom
daffl merged 2 commits intofeathersjs:dovefrom
Conversation
Member
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request will resolves an issue with the resultResolver in combination with a paginated services.
Currently the schema resultResolver resolves the result on context.data. This will end up in an issue if you have a service configured with pagination enabled.
Before the resultResolver is running we have the properties
total,limit,skipanddataoncontext.result. After all properties are resolved, the result of it will set tocontext.result. That means, that the paginated result structure gets los.