Skip to content

Add community SDK section to API docs#992

Merged
woop merged 1 commit into
feast-dev:masterfrom
MichaelHirn:docs/community-sdks
Sep 10, 2020
Merged

Add community SDK section to API docs#992
woop merged 1 commit into
feast-dev:masterfrom
MichaelHirn:docs/community-sdks

Conversation

@MichaelHirn

@MichaelHirn MichaelHirn commented Sep 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

including reference to community-provided Node.js SDK

What this PR does / why we need it:

  1. Adds a Community Contributions section in the reference > api docs
  2. Adds a link to the community provided Node.js SDK

cc @woop

Which issue(s) this PR fixes:

Does not fix an issue

Does this PR introduce a user-facing change?:

NONE

Notes

  • CLA signed
  • ❓I'm not sure if only (docs/reference/api/README.md) or also (docs/reference/api.md) need to be edited. I got the feeling that docs/reference/api.md might be stale, but edited it anyway

@MichaelHirn
Add community SDK section to API docs
e2a6689 
including reference to community-provided Node.js SDK
@feast-ci-bot

feast-ci-bot commented Sep 9, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MichaelHirn
To complete the pull request process, please assign pyalex
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

feast-ci-bot commented Sep 9, 2020

Copy link
Copy Markdown
Collaborator

Hi @MichaelHirn. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MichaelHirn

MichaelHirn commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

/assign @pyalex

@woop

woop commented Sep 10, 2020

Copy link
Copy Markdown
Member

/lgtm

@woop woop merged commit e0dfb67 into feast-dev:master Sep 10, 2020
@woop

woop commented Sep 10, 2020

Copy link
Copy Markdown
Member

@MichaelHirn you should probably backport this to the 0.7 branch as well, because that is what is going to be live on docs.feast.dev

@feast-ci-bot

feast-ci-bot commented Sep 10, 2020

Copy link
Copy Markdown
Collaborator

@MichaelHirn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end e2a6689 link /test test-end-to-end

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MichaelHirn MichaelHirn mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@woop woop Awaiting requested review from woop

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

@woop woop

Labels

area/documentation kind/housekeeping lgtm needs-ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelHirn @feast-ci-bot @woop @pyalex