Skip to content

Add community SDK section to API docs [Backporting v0.7-branch]#997

Merged
woop merged 1 commit into
feast-dev:v0.7-branchfrom
MichaelHirn:docs/community-sdks
Sep 10, 2020
Merged

Add community SDK section to API docs [Backporting v0.7-branch]#997
woop merged 1 commit into
feast-dev:v0.7-branchfrom
MichaelHirn:docs/community-sdks

Conversation

@MichaelHirn

@MichaelHirn MichaelHirn commented Sep 10, 2020

Copy link
Copy Markdown
Contributor

including reference to community-provided Node.js SDK

What this PR does / why we need it:

"Backports" the original PR #992 into the v0.7-branch so changes get published in the docs.

cc @woop

Which issue(s) this PR fixes:

Does not fix an issue

Does this PR introduce a user-facing change?:

NONE

@MichaelHirn
Add community SDK section to API docs
e2a6689 
including reference to community-provided Node.js SDK
@feast-ci-bot

feast-ci-bot commented Sep 10, 2020

Copy link
Copy Markdown
Collaborator

Hi @MichaelHirn. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MichaelHirn

MichaelHirn commented Sep 10, 2020

Copy link
Copy Markdown
Contributor Author

/assign @woop

@feast-ci-bot

feast-ci-bot commented Sep 10, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelHirn, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop merged commit 19b2aaf into feast-dev:v0.7-branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto davidheryanto is a code owner

@khorshuheng khorshuheng Awaiting requested review from khorshuheng khorshuheng is a code owner

@pyalex pyalex Awaiting requested review from pyalex pyalex is a code owner

@zhilingc zhilingc Awaiting requested review from zhilingc zhilingc is a code owner

Assignees

@woop woop

Labels

approved kind/housekeeping needs-kind needs-ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelHirn @feast-ci-bot @woop