Allow maps in environment variables in helm charts - #987
Merged
Conversation
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
September 8, 2020 01:45
pyalex
force-pushed
the
allow-envvars-map
branch
from
September 8, 2020 03:07
92ab9bc to
10679ce
Compare
Collaborator
Author
|
/test test-end-to-end-redis-cluster |
khorshuheng
approved these changes
Sep 8, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently it's not possible to use more complicated expressions (than string or int) as environment variable in kubernetes
Deploymentobject via helm charts.Mapstructure could be useful to provide kube metadata as parameter to feast services.Now this can be achieved with
--set envOverrides.MY_POD_NAMESPACE.fieldRef.fieldPath=metadata.namespaceWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: