Skip to content

Commit c9eb264

Browse files
pyalexpyalex
authored
Allow maps in environment variables in helm charts (#987)
* allow map in envvars overrides * fix helm syntax
1 parent 1f85cec commit c9eb264

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

‎infra/charts/feast/charts/feast-core/templates/deployment.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,12 @@ spec:
100100

101101
{{- range $key, $value := .Values.envOverrides }}
102102
- name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
103+
{{- if eq (kindOf $value) "map" }}
104+
valueFrom:
105+
{{- toYaml $value | nindent 12}}
106+
{{- else }}
103107
value: {{ $value | quote }}
108+
{{- end}}
104109
{{- end }}
105110

106111
command:

‎infra/charts/feast/charts/feast-jobcontroller/templates/deployment.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,12 @@ spec:
100100

101101
{{- range $key, $value := .Values.envOverrides }}
102102
- name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
103+
{{- if eq (kindOf $value) "map" }}
104+
valueFrom:
105+
{{- toYaml $value | nindent 12 }}
106+
{{- else }}
103107
value: {{ $value | quote }}
108+
{{- end }}
104109
{{- end }}
105110

106111
command:

‎infra/charts/feast/charts/feast-serving/templates/deployment.yaml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,12 @@ spec:
9292

9393
{{- range $key, $value := .Values.envOverrides }}
9494
- name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
95+
{{- if eq (kindOf $value) "map" }}
96+
valueFrom:
97+
{{- toYaml $value | nindent 12 }}
98+
{{- else }}
9599
value: {{ $value | quote }}
100+
{{- end }}
96101
{{- end }}
97102

98103
command:

0 commit comments

Comments
 (0)