Skip to content

Fix grpc security variables name and missing exec qualifier in docker.dev - #935

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
Cimpress-MCP:fix-grpc-ssl-variables
Aug 6, 2020
Merged

Fix grpc security variables name and missing exec qualifier in docker.dev#935
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
Cimpress-MCP:fix-grpc-ssl-variables

Conversation

@jmelinav

@jmelinav jmelinav commented Aug 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Grpc security variable names in application.yml are incorrect. Also exec qualifiers are missing from DockerFile.dev
Which issue(s) this PR fixes:

Related #823

Does this PR introduce a user-facing change?:No

previous behavior : enabling grpc security and setting valid server.crt and server.key, throws an error. 
Also docker images build using DockerFile.dev will not boot.

With this PR, enabling security shouldn't throw any error if valid server.crt and server.key are set.
Images build using DockerFile.dev will boot without any errors.

@feast-ci-bot

feast-ci-bot commented Aug 5, 2020

Copy link
Copy Markdown
Collaborator

Hi @jmelinav. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmelinav

jmelinav commented Aug 5, 2020

Copy link
Copy Markdown
Collaborator Author

/kind bug

@jmelinav

jmelinav commented Aug 5, 2020

Copy link
Copy Markdown
Collaborator Author

/assign @pyalex

@feast-ci-bot

feast-ci-bot commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelinav, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Aug 6, 2020

Copy link
Copy Markdown
Member

/lgtm

@woop woop added the ok-to-test label Aug 6, 2020
@woop

woop commented Aug 6, 2020

Copy link
Copy Markdown
Member

Remember to add a release note to bugs, thanks for the contribution @jmelinav!

@jmelinav

jmelinav commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-auth

@feast-ci-bot
feast-ci-bot merged commit d2d47e1 into feast-dev:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@davidheryanto davidheryanto Awaiting requested review from davidheryanto
@khorshuheng khorshuheng Awaiting requested review from khorshuheng
@pyalex pyalex Awaiting requested review from pyalex
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@pyalex pyalex

@woop woop

Labels

approved kind/bug lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmelinav @feast-ci-bot @woop @pyalex