Skip to content

Commit d2d47e1

Browse files
authored
Fix grpc security variables name, and add exec qualifier to docker.dev files. (#935)
1 parent 74beb5d commit d2d47e1

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

core/src/main/resources/application.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ grpc:
113113
port: 6565
114114
security:
115115
enabled: false
116-
certificateChainPath: server.crt
117-
privateKeyPath: server.key
116+
certificateChain: server.crt
117+
privateKey: server.key
118118

119119
spring:
120120
jpa:

infra/docker/core/Dockerfile.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM openjdk:11-jre
22
ARG REVISION=dev
3-
ADD $PWD/core/target/feast-core-$REVISION.jar /opt/feast/feast-core.jar
3+
ADD $PWD/core/target/feast-core-$REVISION-exec.jar /opt/feast/feast-core.jar
44
CMD ["java",\
55
"-Xms2048m",\
66
"-Xmx2048m",\

infra/docker/serving/Dockerfile.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ARG REVISION=dev
77
RUN wget -q https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/v0.3.1/grpc_health_probe-linux-amd64 \
88
-O /usr/bin/grpc-health-probe && \
99
chmod +x /usr/bin/grpc-health-probe
10-
ADD $PWD/serving/target/feast-serving-$REVISION.jar /opt/feast/feast-serving.jar
10+
ADD $PWD/serving/target/feast-serving-$REVISION-exec.jar /opt/feast/feast-serving.jar
1111
CMD ["java",\
1212
"-Xms1024m",\
1313
"-Xmx1024m",\

serving/src/main/resources/application.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ grpc:
114114
port: ${GRPC_PORT:6566}
115115
security:
116116
enabled: false
117-
certificateChainPath: server.crt
118-
privateKeyPath: server.key
117+
certificateChain: server.crt
118+
privateKey: server.key
119119

120120
server:
121121
# The port number on which the Tomcat webserver that serves REST API endpoints should listen

0 commit comments

Comments
 (0)