Bypass authentication for metric endpoints - #862
Merged
Conversation
woop
requested review from
davidheryanto,
khorshuheng,
pyalex and
zhilingc
as code owners
July 6, 2020 13:33
woop
force-pushed
the
fix-authentication-bugs
branch
from
July 7, 2020 01:23
9e32cb4 to
0dee96c
Compare
Member
Author
|
/test test-end-to-end-auth |
pyalex
approved these changes
Jul 7, 2020
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Member
Author
|
/test test-end-to-end-batch |
Collaborator
|
@woop: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
/metricsand/actuatorendpoints require authentication. Most users do not want auth on these utility endpoints, as they will typically not be exposed. This bug fix ensures that security is not applied to these two HTTP endpoints.Furthermore, the current Auth test suite needs to be extended to actually catch these regressions. It can be tracked here #860
Does this PR introduce a user-facing change?: