Skip to content

Bypass authentication for metric endpoints on Serving. - #936

Merged
pyalex merged 2 commits into
feast-dev:masterfrom
mrzzy:bypass-metric-auth-serving
Aug 6, 2020
Merged

Bypass authentication for metric endpoints on Serving.#936
pyalex merged 2 commits into
feast-dev:masterfrom
mrzzy:bypass-metric-auth-serving

Conversation

@mrzzy

@mrzzy mrzzy commented Aug 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Follow up of #862 to extend Authentication Bypass for metrics access to Serving for the /metrics and /actuator endpoints.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@mrzzy
mrzzy requested a review from zhilingc as a code owner August 6, 2020 04:31
@khorshuheng

khorshuheng commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-batch

1 similar comment
@khorshuheng

khorshuheng commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-batch

@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Aug 6, 2020
@pyalex pyalex added the kind/bug label Aug 6, 2020
@mrzzy

mrzzy commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-batch

@khorshuheng
khorshuheng requested review from khorshuheng and removed request for zhilingc August 6, 2020 07:43
@feast-ci-bot

feast-ci-bot commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, mrzzy, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrzzy

mrzzy commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator Author

/test test-end-to-end-batch

@pyalex

pyalex commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

/test test-end-to-end-batch-dataflow

@pyalex

pyalex commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

/lgtm

@pyalex
pyalex merged commit 74beb5d into feast-dev:master Aug 6, 2020
@feast-ci-bot

feast-ci-bot commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

@mrzzy: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-batch-dataflow 3b44161 link /test test-end-to-end-batch-dataflow

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyalex pyalex pyalex approved these changes
@khorshuheng khorshuheng khorshuheng approved these changes

Assignees

@pyalex pyalex

Labels

approved kind/bug lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrzzy @khorshuheng @feast-ci-bot @pyalex