Skip to content

test: Remove flaky key encoding timing assertion #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larrysingleton007 wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −26
Open

test: Remove flaky key encoding timing assertion #6746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions sdk/python/tests/unit/infra/test_key_encoding_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,32 +236,6 @@ def test_optimization_preserves_sorting():
assert [v.string_val for v in deserialized.entity_values] == expected_sorted_values


def test_performance_bounds_single_entity():
"""Regression test to ensure single entity performance meets minimum bounds."""
import time

entity_key = EntityKeyProto(
join_keys=["user_id"], entity_values=[ValueProto(string_val="user123")]
)

# Measure serialization time for 1000 operations
start = time.perf_counter()
for _ in range(1000):
serialize_entity_key(entity_key, entity_key_serialization_version=3)
serialize_time = time.perf_counter() - start

# Measure deserialization time
serialized = serialize_entity_key(entity_key, entity_key_serialization_version=3)
start = time.perf_counter()
for _ in range(1000):
deserialize_entity_key(serialized, entity_key_serialization_version=3)
deserialize_time = time.perf_counter() - start

# Performance bounds with generous thresholds to avoid flaky failures on CI runners
assert serialize_time < 0.2, f"Serialization too slow: {serialize_time:.4f}s"
assert deserialize_time < 0.2, f"Deserialization too slow: {deserialize_time:.4f}s"


def test_non_ascii_prefix_compatibility():
"""Critical test: ensure prefix serialization matches full entity key serialization for non-ASCII keys."""
# Test with non-ASCII characters that have different byte vs character lengths
Expand Down
Loading