test: Remove flaky key encoding timing assertion - #6746
Open
larrysingleton007 wants to merge 1 commit into
Open
Conversation
Fixes feast-dev#6745 Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6746 +/- ##
==========================================
- Coverage 46.82% 46.80% -0.02%
==========================================
Files 415 415
Lines 50406 50406
Branches 7215 7215
==========================================
- Hits 23601 23592 -9
- Misses 25155 25163 +8
- Partials 1650 1651 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes
test_performance_bounds_single_entityfrom the parallel unit suite. The test measures 1,000 operations against an absolute 0.2-second wall-clock limit, which remains sensitive to shared-runner contention after two earlier threshold increases.Correctness remains covered by
test_single_entity_fast_path. Performance remains covered bysdk/python/tests/benchmarks/test_key_encoding_benchmarks.py, where pytest-benchmark reports calibrated results instead of enforcing an absolute wall-clock assertion in the unit suite.Testing
Review requests
kind/bugok-to-testFixes #6745