Skip to content

feat(operator): Add tolerations and nodeSelector to the FeatureStore CR #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShumzZzZz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(operator): Add tolerations and nodeSelector to the FeatureStore CR #6741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions infra/feast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,15 @@ type FeatureStoreServices struct {
// pod anti-affinity rule to prefer spreading pods across nodes.
// +optional
Affinity *corev1.Affinity `json:"affinity,omitempty"`
// Tolerations are applied to the FeatureStore deployment pods, allowing them to
// be scheduled onto nodes with matching taints.
// +optional
Tolerations []corev1.Toleration `json:"tolerations,omitempty"`
// NodeSelector is a selector which must be true for the FeatureStore deployment
// pods to fit on a node. This selector must match a node's labels for the pod to
// be scheduled on that node.
// +optional
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
// ResourceClaims defines which ResourceClaims must be allocated
// and reserved before the Pod is allowed to start. The resources
// will be made available to those containers which consume them
Expand Down
14 changes: 14 additions & 0 deletions infra/feast-operator/api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

82 changes: 82 additions & 0 deletions infra/feast-operator/bundle/manifests/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,6 +1761,13 @@ spec:
description: InitImage overrides the image for init containers
(feast-init, feast-apply).
type: string
nodeSelector:
additionalProperties:
type: string
description: |-
NodeSelector is a selector which must be true for the FeatureStore deployment
pods to fit on a node.
type: object
offlineStore:
description: OfflineStore configures the offline store service
properties:
Expand Down Expand Up @@ -4359,6 +4366,40 @@ spec:
type: string
type: object
type: object
tolerations:
description: |-
Tolerations are applied to the FeatureStore deployment pods, allowing them to
be scheduled onto nodes with matching...
items:
description: |-
The pod this Toleration is attached to tolerates any taint that matches
the triple <key,value,effect> using the...
properties:
effect:
description: Effect indicates the taint effect to match.
Empty means match all taint effects.
type: string
key:
description: Key is the taint key that the toleration applies
to. Empty means match all taint keys.
type: string
operator:
description: |-
Operator represents a key's relationship to the value.
Valid operators are Exists, Equal, Lt, and Gt. Defaults to Equal.
type: string
tolerationSeconds:
description: |-
TolerationSeconds represents the period of time the toleration (which must be
of effect NoExecute, otherwise this field...
format: int64
type: integer
value:
description: Value is the taint value the toleration matches
to.
type: string
type: object
type: array
topologySpreadConstraints:
description: TopologySpreadConstraints defines how pods are spread
across topology domains.
Expand Down Expand Up @@ -8101,6 +8142,13 @@ spec:
description: InitImage overrides the image for init containers
(feast-init, feast-apply).
type: string
nodeSelector:
additionalProperties:
type: string
description: |-
NodeSelector is a selector which must be true for the FeatureStore deployment
pods to fit on a node.
type: object
offlineStore:
description: OfflineStore configures the offline store service
properties:
Expand Down Expand Up @@ -10740,6 +10788,40 @@ spec:
type: string
type: object
type: object
tolerations:
description: |-
Tolerations are applied to the FeatureStore deployment pods, allowing them to
be scheduled onto nodes with matching...
items:
description: |-
The pod this Toleration is attached to tolerates any taint that matches
the triple <key,value,effect> using the...
properties:
effect:
description: Effect indicates the taint effect to match.
Empty means match all taint effects.
type: string
key:
description: Key is the taint key that the toleration
applies to. Empty means match all taint keys.
type: string
operator:
description: |-
Operator represents a key's relationship to the value.
Valid operators are Exists, Equal, Lt, and Gt. Defaults to Equal.
type: string
tolerationSeconds:
description: |-
TolerationSeconds represents the period of time the toleration (which must be
of effect NoExecute, otherwise this field...
format: int64
type: integer
value:
description: Value is the taint value the toleration
matches to.
type: string
type: object
type: array
topologySpreadConstraints:
description: TopologySpreadConstraints defines how pods are
spread across topology domains.
Expand Down
82 changes: 82 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,6 +1761,13 @@ spec:
description: InitImage overrides the image for init containers
(feast-init, feast-apply).
type: string
nodeSelector:
additionalProperties:
type: string
description: |-
NodeSelector is a selector which must be true for the FeatureStore deployment
pods to fit on a node.
type: object
offlineStore:
description: OfflineStore configures the offline store service
properties:
Expand Down Expand Up @@ -4359,6 +4366,40 @@ spec:
type: string
type: object
type: object
tolerations:
description: |-
Tolerations are applied to the FeatureStore deployment pods, allowing them to
be scheduled onto nodes with matching...
items:
description: |-
The pod this Toleration is attached to tolerates any taint that matches
the triple <key,value,effect> using the...
properties:
effect:
description: Effect indicates the taint effect to match.
Empty means match all taint effects.
type: string
key:
description: Key is the taint key that the toleration applies
to. Empty means match all taint keys.
type: string
operator:
description: |-
Operator represents a key's relationship to the value.
Valid operators are Exists, Equal, Lt, and Gt. Defaults to Equal.
type: string
tolerationSeconds:
description: |-
TolerationSeconds represents the period of time the toleration (which must be
of effect NoExecute, otherwise this field...
format: int64
type: integer
value:
description: Value is the taint value the toleration matches
to.
type: string
type: object
type: array
topologySpreadConstraints:
description: TopologySpreadConstraints defines how pods are spread
across topology domains.
Expand Down Expand Up @@ -8101,6 +8142,13 @@ spec:
description: InitImage overrides the image for init containers
(feast-init, feast-apply).
type: string
nodeSelector:
additionalProperties:
type: string
description: |-
NodeSelector is a selector which must be true for the FeatureStore deployment
pods to fit on a node.
type: object
offlineStore:
description: OfflineStore configures the offline store service
properties:
Expand Down Expand Up @@ -10740,6 +10788,40 @@ spec:
type: string
type: object
type: object
tolerations:
description: |-
Tolerations are applied to the FeatureStore deployment pods, allowing them to
be scheduled onto nodes with matching...
items:
description: |-
The pod this Toleration is attached to tolerates any taint that matches
the triple <key,value,effect> using the...
properties:
effect:
description: Effect indicates the taint effect to match.
Empty means match all taint effects.
type: string
key:
description: Key is the taint key that the toleration
applies to. Empty means match all taint keys.
type: string
operator:
description: |-
Operator represents a key's relationship to the value.
Valid operators are Exists, Equal, Lt, and Gt. Defaults to Equal.
type: string
tolerationSeconds:
description: |-
TolerationSeconds represents the period of time the toleration (which must be
of effect NoExecute, otherwise this field...
format: int64
type: integer
value:
description: Value is the taint value the toleration
matches to.
type: string
type: object
type: array
topologySpreadConstraints:
description: TopologySpreadConstraints defines how pods are
spread across topology domains.
Expand Down
82 changes: 82 additions & 0 deletions infra/feast-operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,6 +1769,13 @@ spec:
description: InitImage overrides the image for init containers
(feast-init, feast-apply).
type: string
nodeSelector:
additionalProperties:
type: string
description: |-
NodeSelector is a selector which must be true for the FeatureStore deployment
pods to fit on a node.
type: object
offlineStore:
description: OfflineStore configures the offline store service
properties:
Expand Down Expand Up @@ -4367,6 +4374,40 @@ spec:
type: string
type: object
type: object
tolerations:
description: |-
Tolerations are applied to the FeatureStore deployment pods, allowing them to
be scheduled onto nodes with matching...
items:
description: |-
The pod this Toleration is attached to tolerates any taint that matches
the triple <key,value,effect> using the...
properties:
effect:
description: Effect indicates the taint effect to match.
Empty means match all taint effects.
type: string
key:
description: Key is the taint key that the toleration applies
to. Empty means match all taint keys.
type: string
operator:
description: |-
Operator represents a key's relationship to the value.
Valid operators are Exists, Equal, Lt, and Gt. Defaults to Equal.
type: string
tolerationSeconds:
description: |-
TolerationSeconds represents the period of time the toleration (which must be
of effect NoExecute, otherwise this field...
format: int64
type: integer
value:
description: Value is the taint value the toleration matches
to.
type: string
type: object
type: array
topologySpreadConstraints:
description: TopologySpreadConstraints defines how pods are spread
across topology domains.
Expand Down Expand Up @@ -8109,6 +8150,13 @@ spec:
description: InitImage overrides the image for init containers
(feast-init, feast-apply).
type: string
nodeSelector:
additionalProperties:
type: string
description: |-
NodeSelector is a selector which must be true for the FeatureStore deployment
pods to fit on a node.
type: object
offlineStore:
description: OfflineStore configures the offline store service
properties:
Expand Down Expand Up @@ -10748,6 +10796,40 @@ spec:
type: string
type: object
type: object
tolerations:
description: |-
Tolerations are applied to the FeatureStore deployment pods, allowing them to
be scheduled onto nodes with matching...
items:
description: |-
The pod this Toleration is attached to tolerates any taint that matches
the triple <key,value,effect> using the...
properties:
effect:
description: Effect indicates the taint effect to match.
Empty means match all taint effects.
type: string
key:
description: Key is the taint key that the toleration
applies to. Empty means match all taint keys.
type: string
operator:
description: |-
Operator represents a key's relationship to the value.
Valid operators are Exists, Equal, Lt, and Gt. Defaults to Equal.
type: string
tolerationSeconds:
description: |-
TolerationSeconds represents the period of time the toleration (which must be
of effect NoExecute, otherwise this field...
format: int64
type: integer
value:
description: Value is the taint value the toleration
matches to.
type: string
type: object
type: array
topologySpreadConstraints:
description: TopologySpreadConstraints defines how pods are
spread across topology domains.
Expand Down
Loading
Loading