Skip to content

feat(operator): Add tolerations and nodeSelector to the FeatureStore CR - #6741

Open
ShumzZzZz wants to merge 1 commit into
feast-dev:masterfrom
ShumzZzZz:feat_operator_add_toleration_nodeselector_to_featurestore_cr
Open

feat(operator): Add tolerations and nodeSelector to the FeatureStore CR#6741
ShumzZzZz wants to merge 1 commit into
feast-dev:masterfrom
ShumzZzZz:feat_operator_add_toleration_nodeselector_to_featurestore_cr

Conversation

@ShumzZzZz

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Adds optional pod-level scheduling knobs to the FeatureStore CR so users can place the operator-managed Deployment on specific nodes or on nodes with taints:

spec:
  services:
    nodeSelector:
      kubernetes.io/os: linux
    tolerations:
      - key: dedicated
        operator: Equal
        value: feast
        effect: NoSchedule

Both fields live on spec.services, alongside the existing affinity and topologySpreadConstraints. tolerations is applied directly to the pod spec. nodeSelector becomes the base selector, with the pre-existing per-server containerConfigs.nodeSelector overlaid on top (per-service wins on key conflicts), preserving the existing merge-with-mutating-webhook behavior.

Regenerated artifacts: deepcopy, CRD bases, dist/install.yaml, the API reference, and the OLM bundle.

Which issue(s) this PR fixes

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Testing: added unit coverage for top-level nodeSelector, per-service override precedence, and tolerations. go build ./..., go vet ./..., and all non-e2e operator test packages pass.

Allow scheduling the operator-managed Deployment on tainted or specific nodes via spec.services.tolerations and spec.services.nodeSelector, alongside the existing affinity and topologySpreadConstraints fields.

Signed-off-by: Shumin <shumin.zheng@outlook.com>
@ShumzZzZz
ShumzZzZz requested a review from a team as a code owner August 14, 2026 23:03
@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.81%. Comparing base (b8dfcb0) to head (667af35).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6741   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files         415      415           
  Lines       50399    50399           
  Branches     7214     7214           
=======================================
  Hits        23592    23592           
  Misses      25157    25157           
  Partials     1650     1650           
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.13% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8dfcb0...667af35. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants