feat(operator): Add tolerations and nodeSelector to the FeatureStore CR - #6741
Open
ShumzZzZz wants to merge 1 commit into
Open
Conversation
Allow scheduling the operator-managed Deployment on tainted or specific nodes via spec.services.tolerations and spec.services.nodeSelector, alongside the existing affinity and topologySpreadConstraints fields. Signed-off-by: Shumin <shumin.zheng@outlook.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6741 +/- ##
=======================================
Coverage 46.81% 46.81%
=======================================
Files 415 415
Lines 50399 50399
Branches 7214 7214
=======================================
Hits 23592 23592
Misses 25157 25157
Partials 1650 1650
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds optional pod-level scheduling knobs to the FeatureStore CR so users can place the operator-managed Deployment on specific nodes or on nodes with taints:
Both fields live on
spec.services, alongside the existingaffinityandtopologySpreadConstraints.tolerationsis applied directly to the pod spec.nodeSelectorbecomes the base selector, with the pre-existing per-servercontainerConfigs.nodeSelectoroverlaid on top (per-service wins on key conflicts), preserving the existing merge-with-mutating-webhook behavior.Regenerated artifacts: deepcopy, CRD bases,
dist/install.yaml, the API reference, and the OLM bundle.Which issue(s) this PR fixes
N/A
Checks
git commit -s)Testing Strategy
Testing: added unit coverage for top-level nodeSelector, per-service override precedence, and tolerations.
go build ./...,go vet ./..., and all non-e2e operator test packages pass.