Skip to content

fix: RemoteRegistry.apply_saved_dataset() calls the wrong RPC #6740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xKomil wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −1
Open

fix: RemoteRegistry.apply_saved_dataset() calls the wrong RPC #6740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def apply_saved_dataset(
request = RegistryServer_pb2.ApplySavedDatasetRequest(
saved_dataset=saved_dataset.to_proto(), project=project, commit=commit
)
self.stub.ApplyFeatureService(request)
self.stub.ApplySavedDataset(request)

def delete_saved_dataset(self, name: str, project: str, commit: bool = True):
request = RegistryServer_pb2.DeleteSavedDatasetRequest(
Expand Down
28 changes: 28 additions & 0 deletions sdk/python/tests/unit/infra/registry/test_remote_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
import pytest
from google.protobuf.timestamp_pb2 import Timestamp

from feast.infra.offline_stores.file_source import SavedDatasetFileStorage
from feast.infra.registry.remote import RemoteRegistry
from feast.protos.feast.registry import RegistryServer_pb2
from feast.saved_dataset import SavedDataset


@pytest.fixture
Expand Down Expand Up @@ -83,3 +85,29 @@ def test_updated_since_none(remote_registry):
remote_registry.stub.ListAllFeatureViews.call_args[0][0]
)
assert not request.HasField("updated_since")


def test_apply_saved_dataset_calls_apply_saved_dataset_rpc(remote_registry):
"""apply_saved_dataset() must invoke the ApplySavedDataset RPC, not
ApplyFeatureService -- calling the wrong RPC means the server tries to
deserialize an ApplySavedDatasetRequest as an ApplyFeatureServiceRequest,
which the server cannot handle correctly."""
saved_dataset = SavedDataset(
name="test_saved_dataset",
features=["feature_view:feature"],
join_keys=["entity_id"],
storage=SavedDatasetFileStorage(path="/tmp/does-not-need-to-exist.parquet"),
tags={},
)

remote_registry.apply_saved_dataset(saved_dataset, "project", commit=True)

remote_registry.stub.ApplySavedDataset.assert_called_once()
remote_registry.stub.ApplyFeatureService.assert_not_called()

request: RegistryServer_pb2.ApplySavedDatasetRequest = (
remote_registry.stub.ApplySavedDataset.call_args[0][0]
)
assert request.saved_dataset.spec.name == "test_saved_dataset"
assert request.project == "project"
assert request.commit is True
Loading