fix: RemoteRegistry.apply_saved_dataset() calls the wrong RPC - #6740
Open
xKomil wants to merge 1 commit into
Open
fix: RemoteRegistry.apply_saved_dataset() calls the wrong RPC#6740xKomil wants to merge 1 commit into
xKomil wants to merge 1 commit into
Conversation
…oteRegistry.apply_saved_dataset() RemoteRegistry.apply_saved_dataset() builds an ApplySavedDatasetRequest but sends it via the ApplyFeatureService RPC. The server has a dedicated ApplySavedDataset RPC that expects exactly this request type; calling ApplyFeatureService instead means the server tries to interpret an ApplySavedDatasetRequest payload as an ApplyFeatureServiceRequest, so registering a saved dataset through a remote registry never actually persists it as intended. Adds a regression test asserting the correct RPC is invoked. Signed-off-by: xKomil <plociu1104@gmail.com>
ntkathole
approved these changes
Aug 14, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6740 +/- ##
=======================================
Coverage 46.81% 46.81%
=======================================
Files 415 415
Lines 50399 50399
Branches 7214 7214
=======================================
+ Hits 23592 23595 +3
+ Misses 25157 25155 -2
+ Partials 1650 1649 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
RemoteRegistry.apply_saved_dataset()(sdk/python/feast/infra/registry/remote.py) builds anApplySavedDatasetRequest, but sends it through theApplyFeatureServiceRPC instead of the dedicatedApplySavedDatasetRPC:The server (
sdk/python/feast/registry_server.py) already implements a correctApplySavedDatasethandler that expects exactly this request shape and forwards it toproxied_registry.apply_saved_dataset(...). Because the client callsApplyFeatureServiceinstead, the server tries to handle anApplySavedDatasetRequestpayload through theApplyFeatureServiceRPC/ApplyFeatureServiceRequestshape, so registering aSavedDatasetagainst a remote registry (registry_type: remote) never reaches the intended handler and the saved dataset is not correctly persisted.This was found while working with a Feast deployment using a remote registry (Feast Operator / OpenShift), trying to register a
SavedDatasetviastore.registry.apply_saved_dataset(...)after usingstore.create_saved_dataset()'s.persist()step wasn't an option for the offline store in use.The fix is a one-line change: call
self.stub.ApplySavedDataset(request)instead ofself.stub.ApplyFeatureService(request).Which issue(s) this PR fixes:
None filed yet — I searched open/closed issues and PRs for
ApplySavedDataset/apply_saved_datasetand didn't find an existing report.Checks
git commit -s)Testing Strategy
Added
test_apply_saved_dataset_calls_apply_saved_dataset_rpctosdk/python/tests/unit/infra/registry/test_remote_registry.py, following the existingremote_registryfixture pattern in that file. Verified locally:ApplyFeatureService.assert_not_called()fails because it was called).ApplySavedDatasetRequest) is unchanged, only the RPC method changes.test_remote_registry.pysuite (5 tests) passes.Misc
Small, isolated fix — one production line changed, plus a regression test. No API changes.