Skip to content

feat: Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanskar-singh-2403 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support #6707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@
"filename": "infra/feast-operator/api/v1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 958
"line_number": 959
}
],
"infra/feast-operator/api/v1/zz_generated.deepcopy.go": [
Expand Down Expand Up @@ -989,7 +989,7 @@
"filename": "infra/feast-operator/api/v1alpha1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 663
"line_number": 664
}
],
"infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go": [
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/offline-stores/hybrid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ project: my_feature_repo
registry: data/registry.db
provider: local
offline_store:
type: hybrid_offline_store.HybridOfflineStore
type: hybrid
offline_stores:
- type: spark
conf:
Expand Down
3 changes: 2 additions & 1 deletion infra/feast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ var ValidOfflineStoreFilePersistenceTypes = []string{
// OfflineStoreDBStorePersistence configures the DB store persistence for the offline store service
type OfflineStoreDBStorePersistence struct {
// Type of the persistence type you want to use.
// +kubebuilder:validation:Enum=snowflake.offline;bigquery;redshift;spark;postgres;trino;athena;mssql;couchbase.offline;clickhouse;ray;oracle
// +kubebuilder:validation:Enum=snowflake.offline;bigquery;redshift;spark;postgres;trino;athena;mssql;couchbase.offline;clickhouse;ray;oracle;hybrid
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -549,6 +549,7 @@ var ValidOfflineStoreDBStorePersistenceTypes = []string{
"clickhouse",
"ray",
"oracle",
"hybrid",
}

// OnlineStore configures the online store service
Expand Down
3 changes: 2 additions & 1 deletion infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ var ValidOfflineStoreFilePersistenceTypes = []string{
// OfflineStoreDBStorePersistence configures the DB store persistence for the offline store service
type OfflineStoreDBStorePersistence struct {
// Type of the persistence type you want to use.
// +kubebuilder:validation:Enum=snowflake.offline;bigquery;redshift;spark;postgres;trino;athena;mssql;couchbase.offline;clickhouse;ray
// +kubebuilder:validation:Enum=snowflake.offline;bigquery;redshift;spark;postgres;trino;athena;mssql;couchbase.offline;clickhouse;ray;hybrid
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -357,6 +357,7 @@ var ValidOfflineStoreDBStorePersistenceTypes = []string{
"couchbase.offline",
"clickhouse",
"ray",
"hybrid",
}

// OnlineStore configures the online store service
Expand Down
4 changes: 4 additions & 0 deletions infra/feast-operator/bundle/manifests/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,6 +1881,7 @@ spec:
- clickhouse
- ray
- oracle
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -8211,6 +8212,7 @@ spec:
- clickhouse
- ray
- oracle
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -13771,6 +13773,7 @@ spec:
- couchbase.offline
- clickhouse
- ray
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -18292,6 +18295,7 @@ spec:
- couchbase.offline
- clickhouse
- ray
- hybrid
type: string
required:
- secretRef
Expand Down
4 changes: 4 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,6 +1881,7 @@ spec:
- clickhouse
- ray
- oracle
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -8211,6 +8212,7 @@ spec:
- clickhouse
- ray
- oracle
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -13771,6 +13773,7 @@ spec:
- couchbase.offline
- clickhouse
- ray
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -18292,6 +18295,7 @@ spec:
- couchbase.offline
- clickhouse
- ray
- hybrid
type: string
required:
- secretRef
Expand Down
4 changes: 4 additions & 0 deletions infra/feast-operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,6 +1889,7 @@ spec:
- clickhouse
- ray
- oracle
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -8219,6 +8220,7 @@ spec:
- clickhouse
- ray
- oracle
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -13779,6 +13781,7 @@ spec:
- couchbase.offline
- clickhouse
- ray
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -18300,6 +18303,7 @@ spec:
- couchbase.offline
- clickhouse
- ray
- hybrid
type: string
required:
- secretRef
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/repo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
"clickhouse": "feast.infra.offline_stores.contrib.clickhouse_offline_store.clickhouse.ClickhouseOfflineStore",
"ray": "feast.infra.offline_stores.contrib.ray_offline_store.ray.RayOfflineStore",
"oracle": "feast.infra.offline_stores.contrib.oracle_offline_store.oracle.OracleOfflineStore",
"hybrid": "feast.infra.offline_stores.hybrid_offline_store.HybridOfflineStore",
}

FEATURE_SERVER_CONFIG_CLASS_FOR_TYPE = {
Expand Down
Loading