feat: Add hybrid to ValidOfflineStoreDBStorePersistenceTypes for HybridOfflineStore support - #6707
Open
sanskar-singh-2403 wants to merge 1 commit into
Conversation
sanskar-singh-2403
force-pushed
the
feat/hybrid-offline-store-persistence
branch
from
August 5, 2026 15:30
162648c to
e6258ea
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6707 +/- ##
=======================================
Coverage 46.77% 46.77%
=======================================
Files 414 414
Lines 50191 50191
Branches 7181 7181
=======================================
Hits 23475 23475
Misses 25077 25077
Partials 1639 1639
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…idOfflineStore support The Feast SDK supports HybridOfflineStore, which routes offline operations to different backends based on each FeatureView's batch_source, but the operator's FeatureStore CRD did not allow type: hybrid in the offline store persistence enum, blocking configuration via the CR. Mirrors the online store fix in feast-dev#5810: - Register hybrid in OFFLINE_STORE_CLASS_FOR_TYPE so the type resolves to HybridOfflineStore (the SDK map previously had this only for the online store). - Add hybrid to the offline DB store enum and ValidOfflineStoreDBStorePersistenceTypes in both api/v1 and api/v1alpha1, and regenerate the CRD manifests (config/crd/bases, dist/install.yaml, bundle/manifests). - Update the offline hybrid doc to use the short type: hybrid form. Fixes feast-dev#6701 Signed-off-by: Sanskar Singh <sanskarsinghty1234@gmail.com>
sanskar-singh-2403
force-pushed
the
feat/hybrid-offline-store-persistence
branch
from
August 5, 2026 15:40
e6258ea to
739703c
Compare
Contributor
Author
|
@ntkathole the test timed out ig, can we re-run this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Feast SDK supports
HybridOfflineStore, which routes offline operations todifferent backends based on each FeatureView's
batch_source. However, the FeastOperator's
FeatureStoreCRD did not includehybridinValidOfflineStoreDBStorePersistenceTypes, so settingtype: hybridin the CRfailed admission validation and blocked configuring it via the secret
pass-through mechanism, even though the SDK and server fully support it.
This mirrors the online store fix in #5810 (commit
678589b), applied to theoffline store:
hybridinOFFLINE_STORE_CLASS_FOR_TYPEinsdk/python/feast/repo_config.pyso the type resolves toHybridOfflineStore.The SDK map previously carried this alias only for the online store, so
type: hybridwas already valid online but not offline.hybridto the offline DB store enum andValidOfflineStoreDBStorePersistenceTypesin bothapi/v1andapi/v1alpha1.config/crd/bases,dist/install.yaml,bundle/manifests) with controller-genv0.18.0.type: hybridform, matching theonline doc change in fix: Add hybrid online store to ONLINE_STORE_CLASS_FOR_TYPE mapping #5810.
No other operator changes are needed: the existing secret pass-through mechanism
already handles the full hybrid config, identically to how it works for the online
hybrid store.
Which issue(s) this PR fixes:
Fixes #6701
Checks
git commit -s)Testing Strategy
Misc
Verification performed locally:
go build ./...andgo vet ./api/... ./internal/...ininfra/feast-operatorboth pass.hybridis now inOFFLINE_STORE_CLASS_FOR_TYPE, resolves toHybridOfflineStore, andget_offline_config_from_type("hybrid")returnsHybridOfflineStoreConfig. This keeps the operator'stest/data-source-typescross-check (operator persistence types vs the SDK store maps) consistent in both directions.