fix: Set FIPS cipher suites before pyarrow.flight import to prevent crash on IBM Power (#164) - #6664
Merged
Merged
Conversation
jyejare
force-pushed
the
auto-sync/upstream/164
branch
from
July 30, 2026 07:39
01e0c70 to
d9cb234
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6664 +/- ##
==========================================
+ Coverage 46.35% 46.36% +0.01%
==========================================
Files 414 414
Lines 50052 50072 +20
Branches 7151 7154 +3
==========================================
+ Hits 23201 23218 +17
- Misses 25229 25231 +2
- Partials 1622 1623 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
jyejare
force-pushed
the
auto-sync/upstream/164
branch
from
July 30, 2026 07:51
d9cb234 to
cb02a08
Compare
ntkathole
approved these changes
Jul 30, 2026
added 2 commits
July 30, 2026 14:06
…rash on IBM Power RHOAIENG-78595 # What this PR does / why we need it: The Feast offline container crashes in CrashLoopBackOff on FIPS-enabled OpenShift clusters running IBM Power (ppc64le). The existing FIPS cipher suite fix (RHOAIENG-70153) set GRPC_SSL_CIPHER_SUITES in `start_server()`, but pyarrow.flight was already imported at module level. On IBM Power, gRPC reads this env var during shared-library initialization, so the late configuration had no effect. This fix moves the FIPS cipher configuration to module level — before the pyarrow.flight import — so the env var is present when gRPC initializes its SSL context. The `_configure_grpc_fips()` call in `start_server()` is retained as a safety net. # Which issue(s) this PR fixes: Fixes RHOAIENG-78595 # Checks - [x] I've made sure the tests are passing. - [x] My PR title follows conventional commits format ## Testing Strategy - [x] Unit tests Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com> Signed-off-by: aipcc-bot <aipcc-bot@redhat.com> Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com>
# What this PR does / why we need it: Move FIPS log message below logger initialization so it is emitted at INFO level instead of being silently dropped under the default WARNING threshold. Replace importlib.reload-based import ordering test with a subprocess-based test that exercises fresh Python import from scratch, ensuring pyarrow.flight is not cached in sys.modules and the GRPC_SSL_CIPHER_SUITES ordering check is genuine. # Which issue(s) this PR fixes: Fixes RHOAIENG-78595 # Checks - [x] I've made sure the tests are passing. - [x] My PR title follows conventional commits format ## Testing Strategy - [x] Unit tests Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com> Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com>
ntkathole
force-pushed
the
auto-sync/upstream/164
branch
from
July 30, 2026 08:36
cb02a08 to
bf0a471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-sync from opendatahub-io/feast (PR #164)
Cherry-pick of opendatahub-io#164 to upstream
masterbranch.This PR was automatically created from the midstream repository.
Made with Cursor