Skip to content

Check validity of event timestamp in ValidateFeatureRowDoFn - #164

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pradithya:validate_timestamp
Mar 28, 2019
Merged

Check validity of event timestamp in ValidateFeatureRowDoFn#164
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pradithya:validate_timestamp

Conversation

@pradithya

@pradithya pradithya commented Mar 28, 2019

Copy link
Copy Markdown
Collaborator

Add validity check to event timestamp of a Feature Row so that it could be safely discarded during data validation check.

Fix #163

@thirteen37

Copy link
Copy Markdown
Collaborator

/approve

@zhilingc

Copy link
Copy Markdown
Collaborator

/lgtm

@pradithya

Copy link
Copy Markdown
Collaborator Author

/approve

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya, thirteen37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 5b6c7db into feast-dev:master Mar 28, 2019
patelchaitany pushed a commit to patelchaitany/feast that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants