fix: Resolve UI build warnings#6529
Merged
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
useCallback/useMemo.Why
The nightly Python SDK release now builds the embedded UI from the local
ui/source. In GitHub Actions, React treats ESLint warnings as build errors becauseCI=true, so existing UI warnings caused thepublish-nightly-python-sdk / build-wheels / Build wheels and sourcejob to fail duringmake build-ui.Failing run: https://github.com/feast-dev/feast/actions/runs/27618353749
Validation
CI=true make build-uiNote: local verification used the repo-pinned
yarn@1.22.22. The shell Node version wasv26.3.0; the repo.nvmrcrequestsv22.13.1.